Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove Gemfile.lock #53

Merged
merged 2 commits into from

3 participants

@rmm5t

Gemfile.lock was correctly in the .gitignore file, but was also committed to the
repository. See
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Furthermore, it was locked to a version of memcached that I couldn't get to compile
on Lion.

rmm5t added some commits
@rmm5t rmm5t Removed Gemfile.lock
Gemfile.lock was correctly in the .gitignore file, but was also committed to the
repository.  See
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Furthermore, it was locked to a version of memcached that I could get to compile
on Lion.
c01c0a9
@rmm5t rmm5t Added `bundle exec` to the `bacon` calls for test and spec tasks 13a41c3
@nbibler

:+1: Never good to have a Gemfile.lock in a gem's repository. Rely on the gemspec for that.

@rtomayko
Owner

@rmm5t Sorry for taking so long to get back on all this great work. I'm digging in now.

@rtomayko rtomayko merged commit 6760978 into rtomayko:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 10, 2012
  1. @rmm5t

    Removed Gemfile.lock

    rmm5t authored
    Gemfile.lock was correctly in the .gitignore file, but was also committed to the
    repository.  See
    http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
    
    Furthermore, it was locked to a version of memcached that I could get to compile
    on Lion.
  2. @rmm5t
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 24 deletions.
  1. +0 −22 Gemfile.lock
  2. +2 −2 Rakefile
View
22 Gemfile.lock
@@ -1,22 +0,0 @@
-PATH
- remote: .
- specs:
- rack-cache (1.0.3)
- rack (>= 0.4)
-
-GEM
- remote: http://rubygems.org/
- specs:
- bacon (1.1.0)
- dalli (1.0.5)
- memcached (1.3)
- rack (1.3.2)
-
-PLATFORMS
- ruby
-
-DEPENDENCIES
- bacon
- dalli
- memcached
- rack-cache!
View
4 Rakefile
@@ -15,13 +15,13 @@ end
desc 'Run specs with unit test style output'
task :test => FileList['test/*_test.rb'] do |t|
suite = t.prerequisites
- sh "bacon -q -I.:lib:test #{suite.join(' ')}", :verbose => false
+ sh "bundle exec bacon -q -I.:lib:test #{suite.join(' ')}", :verbose => false
end
desc 'Run specs with story style output'
task :spec => FileList['test/*_test.rb'] do |t|
suite = t.prerequisites
- sh "bacon -I.:lib:test #{suite.join(' ')}", :verbose => false
+ sh "bundle exec bacon -I.:lib:test #{suite.join(' ')}", :verbose => false
end
desc 'Generate test coverage report'
Something went wrong with that request. Please try again.