Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rescue StandardError instead of Exception so things like interrupts continue to work. #83

Merged
merged 1 commit into from Oct 8, 2015

Conversation

Projects
None yet
3 participants
Contributor

nirvdrum commented May 9, 2013

I lack the historical context for the original rescue clauses (dating back to 2009) and don't know if there was a store implementation that would raise an exception that didn't descend from StandardError. But swallowing all exceptions can lead to some unexpected behavior, especially in a multi-threaded environment.

xentek commented May 13, 2013

👍

Collaborator

grosser commented Oct 8, 2015

good catch!

grosser added a commit that referenced this pull request Oct 8, 2015

Merge pull request #83 from nirvdrum/rescue_standard_error
Rescue StandardError instead of Exception so things like interrupts continue to work.

@grosser grosser merged commit 840309e into rtomayko:master Oct 8, 2015

Collaborator

grosser commented Oct 8, 2015

released as 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment