Fix jruby support (fork is not supported on this platform) #66

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mparkachov

Hi Ryan,

I've tried to fix the jruby support by using Albino instead of using local fork to run Pygments. This version passes all the tests on MRI 1.8, all the tests on jruby in 1.8 mode and most of the test on jruby in 1.9 mode. Unfortunately, UTF-8 test is broken. The Albino is using 'posix-spawn' gem to start local Pygments, but the posix-spawn doesn't support any other encoding beside BINARY, actually your issue 4.

The second issue I came across is that the test suite is not running clean with 'redcarpet' but it runs just fine with 'rdiscount'. I've changed gem dependency as well.

So, this pull request in not 100% clean for jruby support, but it may give you some ideas. Actually, it seems like changing Albino to support web service pygments and just calling Albino could be interesting approach.

Cheers,
Maksym.

@auser
auser commented Sep 27, 2011

This would be awesome to add this pull request... in terms of using jruby and rocco together.

Please pull req. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment