Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

No output from Rack::CommonLogger #39

Closed
cyx opened this Issue · 8 comments

6 participants

Cyril David Guillermo Iguaran activestylus Robert A Rupe Damian Janowski
Cyril David

The simplest way I could make it work was by doing this:

cyx@3098530

I know it's a bit hackish though. I tried also experimenting with reopening $stderr / $stdout after forking to the previous values, but unfortunately I couldn't find a way to make it work properly.

Thanks in advance for any help!

Guillermo Iguaran

+1, I'm having same problem

activestylus

+100 - I'm using the Cuba framework and this is the only lib that actually works for reloading the environment. It's brilliant, but I sure do miss the ::CommonLogger output

@cyx thanks for the hack

Robert A

Thanks for the fix! But what might be wrong though? It's not running the code properly after the line run Shotgun::Loader.new(config) ?

Cyril David

Something related to output redirection. It's a bit tricky to fully fix, hence the easier hack. :-)

Rupe

No Rack::CommonLogger output for me either, would be nice if the hack could be officially incorporated...

ryankevans ryankevans referenced this issue from a commit in ryankevans/shotgun
Ryan K. Evans Fixes #39 (Rack::CommonLogger output is lost). Based on cyx/shotgun#3…
…098530
38cc86b
Damian Janowski
Collaborator

@Krajsnick I just submitted #57 which fixes this issue and adds tests.

Damian Janowski
Collaborator

Closing in favor of #57. I intend to merge this very soon. Thanks.

Damian Janowski djanowski closed this
Damian Janowski
Collaborator

The fix is released in 0.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.