Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Calling close on response body inside child process #38

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

skorks commented Feb 29, 2012

For example CommonLogger middleware proxies body and only outputs the log message after something has called 'close' on the response body, so without this things like CommonLogger don't work as intended.

skorks added some commits Feb 29, 2012

Making sure to call close on body
For example CommonLogger middleware proxies body and only
outputs the log message after something has called 'close'
on the response body, so without this things like
CommonLogger don't work as intended.
Don't need CommonLogger by default
We add our own CommonLogger and certainly won't need more than one.

jgarber commented Sep 23, 2013

👍 Should solve no log messages being output

Collaborator

djanowski commented Nov 6, 2014

Can you close in favor of #57 which doesn't comment out lines and adds tests? Let's join forces! :)

Collaborator

djanowski commented Mar 1, 2015

Closing this in favor of #57 which is the Minimal Viable Fix™ and includes a test. Will try to get this merged very soon. Thanks.

@djanowski djanowski closed this Mar 1, 2015

Collaborator

djanowski commented Mar 1, 2015

The fix is released in 0.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment