Tenjin support #11

Closed
wbzyl opened this Issue Nov 3, 2009 · 12 comments

Comments

Projects
None yet
7 participants
Contributor

wbzyl commented Nov 3, 2009

Tenjin is a very fast and full-featured template engine available in several script languages.

Tenjin – the fastest template engine in the world.

--Włodek Bzyl

Collaborator

rkh commented Apr 13, 2011

I'm against including another engine that is not 1.9 compatible. Also, it seems to be no longer maintained.

Contributor

josh commented Apr 13, 2011

Seems bad. We should make it clear that any tilt engine needs to be 1.8.7 and 1.9.x compat.

Collaborator

rkh commented Apr 13, 2011

Judging from the tests that fail, actually making it 1.9 compatible wouldn't be that hard, but since it's not on github (in fact, I can't even find the repository anywhere), and there has not been a release in three years...

Contributor

hannesg commented Nov 4, 2011

Hi there.
I'm using tenjin under 1.9 a lot and i didn't have any problem with it.
It's right, the ruby version is not under developement anymore, but it is pretty mature and fast ( i like it a lot ).
I've already hacked it a bit. Is anyone still interested in this feature?
If so, i would write the code for that.

Collaborator

rkh commented Nov 5, 2011

Last time I checked (see comment above) the tests didn't pass on 1.9. One option would be for you to become the maintainer of it or a fork, that would be fully 1.9 compatible.

Contributor

hannesg commented Nov 5, 2011

Yep, if already contacted the original author yesterday. If he agrees i'll maintain that.

Contributor

hannesg commented Nov 13, 2011

Hi
the author hasn't replied yet, but i've made a first working implementation of the tenjin support.
I would be very pleased if somebody could review the changes:
hannesg/tilt@1b19c79

Thank you!
Hannes

Owner

rtomayko commented Nov 14, 2011

@hannesg: Could you move that to a branch and submit a pull request please? Thanks!

Contributor

hannesg commented Nov 14, 2011

k, done

Contributor

hannesg commented Nov 25, 2011

Hi,
there was a new release ( tenjin 0.7.0 ).
It changed several things but should be compatible. Ruby 1.9. support is explicitly stated in the release message.

I'll check compatiblity over the weekend and send patches if required.

Contributor

josephholsten commented Oct 10, 2014

anyone want to review the patch in #116

Collaborator

judofyr commented Jul 7, 2015

Tenjin hasn't had any updates for about four years. However, if someone really wants it into Tilt I'll accept it if someone opens a new pull request.

@judofyr judofyr closed this Jul 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment