Readme #80

Merged
merged 3 commits into from Apr 26, 2011

Conversation

Projects
None yet
3 participants
Collaborator

rkh commented Apr 15, 2011

Note that the second commit should only be merged if #79 gets merged, too.

Owner

rtomayko commented Apr 15, 2011

Love it. Thanks for this!

Owner

rtomayko commented Apr 15, 2011

Also, #79 will definitely be merged btw. GitHub just moved to Redcarpet for all Markdown processing. It's the best fast markdown lib out there currently IMO.

@judofyr do you want to keep stuff off master until this release goes out or can I go ahead and merge in #79?

Collaborator

judofyr commented Apr 15, 2011

@rtomayko well, as long as the tests pass, I don't see how much harm a new template class would do…

Collaborator

rkh commented Apr 15, 2011

Maybe Redcarped should even be favored over RDiscount.

-- Gesendet von meinem Palm Prē
judofyr <reply@reply.github.com> schrieb am 15.04.2011 16:55:

@rtomayko well, as long as the tests pass, I don't see how much harm a new template class would do…

Reply to this email directly or view it on GitHub:

#80 (comment)

Owner

rtomayko commented Apr 15, 2011

It should. Discount is unsafe in server environments.

One problem this surfaces is that Redcarpet will default to base Markdown and make you enable any extra syntax flags, whereas rdiscount defaults to having a bunch of stuff turned on. That makes using different markdown libs w/ tilt alternates very strange. Not sure what we should do about that.

I think we should leave rdiscount as default for this release.

@rtomayko rtomayko added a commit that referenced this pull request Apr 26, 2011

@rtomayko rtomayko Merged pull request #80 from rkh/readme.
Readme
fff9e98

rtomayko merged commit fff9e98 into rtomayko:master Apr 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment