Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiducials not working correctly #96

Open
tvalimaki opened this issue Aug 23, 2019 · 0 comments
Open

Fiducials not working correctly #96

tvalimaki opened this issue Aug 23, 2019 · 0 comments

Comments

@tvalimaki
Copy link

tvalimaki commented Aug 23, 2019

The raytracing step for fiducial detection scans as far as the maximum range, therefore fiducials that have an obstacle behind them, in range of the sensor, won't be detected. There's a TODO note in the code reflecting this (line 180 in model_fiducial.cc). Is there some reason the max_range_anon couldn't just be replaced with range, which is the distance to the fiducial?

I tested this and it seems to fix the issue. I'm more than happy to create a pull request if this is all that is needed and it doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant