Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Camera interface for Player plugin #32

merged 2 commits into from Jul 5, 2013


None yet
3 participants

jpgr87 commented Dec 13, 2012

I patched in a Camera interface to the latest git master, and fixed a couple of compatibility issues that existed with the latest git and Player 3.0.2.

Tested the camera code using the new camera.cfg and camera.world files I added, plus the playercam utility. You should be able to see the walls of the cave, a white floor, grey walls, and a black sky.

This has been sitting in my "half-done" pile for a while, I figured I'd take a few minutes and get it working and make it apply cleanly to the current git master.

jpgr87 added some commits Dec 13, 2012

Add ifdefs for compatibility with Player < 3.1
The Stage plugin contains some features (graphics2d multiline,
etc.) that were added in Player 3.1.  This commit adds some
code to let the latest version of Stage compile against Player
3.0.2 and earlier.
Add camera interface support to the Player plugin
This commit adds camera interface support to the Player plugin,
based on code originally provided to the project by Kevin Barry.
Images from Stage camera models can now be accessed by Player
clients like "playercam"

rtv added a commit that referenced this pull request Jul 5, 2013

Merge pull request #32 from jpgr87/camera
Camera interface for Player plugin

@rtv rtv merged commit 9a0c727 into rtv:master Jul 5, 2013

This line:
looks like a mistake, but it won't work if i correct it to +#define PLAYER_CAPABILITIES_REQ PLAYER_CAPABILITIES_REQ is this intentional?


jpgr87 replied Nov 10, 2013

It's not a mistake. Player had a misspelled CAPABILTIES request, which was corrected to be CAPABILITIES but there was an oversight where backwards compatible CAPABILTIES definition was not maintained and deprecated properly. This definition is a work-around so that Stage will work with all versions of Player.

Ok, thank you for clarifying.

@jpgr87 jpgr87 deleted the jpgr87:camera branch Feb 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment