rc variable unused in ecc.c file #4

Open
wants to merge 1 commit into
from

2 participants

@bithinalangot

An error was raised while installation of pyECC in ubuntu stating the rc variable in file ecc.c was unused. This warning is preventing it from installation.

Error

building '_pyecc' extension
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include -I/usr/local/include -I/usr/include/python2.7 -c seccure/libseccure.c -o build/temp.linux-x86_64-2.7/seccure/libseccure.o -Wall -Werror
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include -I/usr/local/include -I/usr/include/python2.7 -c seccure/numtheory.c -o build/temp.linux-x86_64-2.7/seccure/numtheory.o -Wall -Werror
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include -I/usr/local/include -I/usr/include/python2.7 -c seccure/ecc.c -o build/temp.linux-x86_64-2.7/seccure/ecc.o -Wall -Werror
seccure/ecc.c: In function ‘point_decompress’:
seccure/ecc.c:111:12: error: variable ‘rc’ set but not used [-Werror=unused-but-set-variable]
seccure/ecc.c: In function ‘pointmul’:
seccure/ecc.c:364:7: error: variable ‘rc’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
"

@rtyler
Owner

This is actually kind of funny, the variable is used but only if -DDEBUG is defined. Let me think on this a little bit, I still think -Werror is a beneficial flag to leave on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment