Commits on Aug 15, 2012
  1. Merge pull request #39 from jeffmccune/fix/master/clean_function_testing

    Use puppetlabs_spec_helper to test parser functions
    jeffmccune committed Aug 15, 2012
Commits on Aug 14, 2012
  1. Use puppetlabs_spec_helper to test parser functions

    Without this patch applied rspec-puppet reaches deep inside of Puppet
    and uses an unsupported and private interface to obtain functions and
    scope instances.  This is a problem because Puppet Labs considers
    internal classes such as Puppet::Parser::Scope as private and internal.
    We change these classes without warning and this is a maintenance issue
    for third party testing tools.
    This patch fixes this maintenance problem by using the compatibility
    layer implemented in the puppetlabs_spec_helper.  When we change the
    internal behavior of private classes such as Puppet::Parser::Scope,
    we'll update the spec helper module methods to provide a version
    agnostic way to get instances of these internal objects.
    As an example, a supported way to get a scope instance is:
    Instead of the private and unsupported method of:
    This patch introduces a Gem dependency onto the puppetlabs_spec_helper
    jeffmccune committed Aug 14, 2012
Commits on Aug 9, 2012
  1. Bump to 0.1.4

    rodjek committed Aug 9, 2012
  2. Fix bug with optional arrays in the matcher

    When a type parameter takes an array with a single value, the compiled version
    only has the single value not as an array.
    rodjek committed Aug 9, 2012
  3. Merge branch 'memoize-build-catalog' of…

    …c-puppet into Jimdo-memoize-build-catalog
    rodjek committed Aug 9, 2012
Commits on Aug 8, 2012
  1. fix tests for rspec-2.11.0

    fungusakafungus committed with rodjek Jul 31, 2012
  2. Merge pull request #36 from bodepd/pre_condition_catalogs_function_te…

    Add support for pre_condition with functions
    Tim Sharpe committed Aug 8, 2012
Commits on Aug 3, 2012
Commits on Aug 2, 2012
  1. Add support for pre_condition with functions

    This commit adds support for using the pre_condition
    hook to specify the source code that should be used to
    compile a catalog that can be introspected by functions for
    testing purposes.
    This allows users to test functions that need access to
    catalog contents.
    This allows the following snippet to test a function that
    needs access to the catalog generated by pre_condition:
      describe 'defined_with_params' do
        #describe 'when resource is passed as a string' do
        let :pre_condition do
          'user { "dan": }'
        it { should run.with_params('User[dan]', {}).and_return('true') }
    Dan Bode committed Aug 1, 2012
Commits on Jul 31, 2012
Commits on Apr 7, 2012
  1. Bump to 0.1.3

    rodjek committed Apr 7, 2012
Commits on Apr 6, 2012
  1. Puppet 2.7 under 1.9.x converts all array members to strings

    This hack should keep things working the same under 1.8 and 1.9
    rodjek committed Apr 6, 2012
  2. Have travis build 1.9

    rodjek committed Apr 6, 2012
Commits on Apr 5, 2012
Commits on Mar 12, 2012
  1. Merge pull request #21 from nanliu/tb/config

    Add Puppet[:config] as a supported option.
    Tim Sharpe committed Mar 12, 2012
Commits on Feb 16, 2012
Commits on Feb 15, 2012
Commits on Jan 20, 2012
  1. bump to 0.1.1

    rodjek committed Jan 20, 2012
Commits on Dec 30, 2011
  1. Merge pull request #18 from bodepd/with_without_methods

    Adds with/without methods
    jeffmccune committed Dec 30, 2011
  2. Add 'without' method

    Adds a method 'without' which accepts a list of
    parameters that should not be defined in the resource.
      it { should contain_service('keystone').without(
        ['restart', 'status']
    Dan Bode committed Dec 29, 2011
Commits on Dec 29, 2011
  1. Add with method to generic matcher

    This commit adds a method 'with' that can be used
    to test mulitple parameters/values with a single
    method call
      it do should contain_service('keystone').with(
        'ensure'     => 'running',
        'enable'     => 'true',
        'hasstatus'  => 'true',
        'hasrestart' => 'true'
      ) end
    It was created as a more condensed alternative to
    chaining methods per parameter to validate.
    Dan Bode committed Dec 29, 2011
  2. Merge pull request #16 from jeffmccune/bug/master/fix_rspec_requirement

    Fix rspec dependency
    jeffmccune committed Dec 29, 2011
  3. Merge pull request #17 from jeffmccune/feature/master/improve_matcher…

    Add Regexp support to with_* matchers and improve error messages
    jeffmccune committed Dec 29, 2011
  4. Add Rake task 'spec'

    Adds the Rake task 'spec' for consistency
    with other Rakefiles in Puppet related projects.
    Dan Bode committed Dec 29, 2011
  5. Add Regexp support to with_* matchers and improve error messages

    Without this patch it is difficult to match portions of long strings
    which are attribute values of resource parameters.  For example, the
    content parameter of a file resource with a multi-line template.
    This patch makes it easier to match portions of the parameter's value by
    passing a Regexp instance to the with_ catch all matcher.
    The use case looks like:
        describe 'with lsbmajdistrelease available' do
          let(:facts) { @facter_facts.merge({'lsbmajdistrelease' => '6'}) }
          it { should_not contain_file('puppetenterprise.repo').with_content(missing_content) }
          it { should contain_package 'pe-ruby-devel' }
          it do
            should contain_file('puppetenterprise.repo').with_content(/baseurl=http/)
            should contain_file('puppetenterprise.repo').with_content(/pe_base/)
            should contain_file('puppetenterprise.repo').with_content(/pe_updates/)
            should contain_file('puppetenterprise.repo').with_content(/pe_extras/)
    This feature allows the same parameter to be matched multiple times using
    multiple different regular expressions.
    This patch also improves the error message by presenting the actual value in
    the catalog when it does not match the expectation.  This change applies to
    both String and Regexp expectation matches.
    The error output now looks like:
        1) pe_devel on redhat el6 os families with lsbmajdistrelease available
           Failure/Error: should contain_file('puppetenterprise.repo').with_content(/JEFF MCCUNE/)
             expected that the catalogue would contain File[puppetenterprise.repo] with content \
             matching `/JEFF MCCUNE/` but its value of `"# KERMIT FROG\n"` does not
    Spec tests have been added to exercise the handling of Regexp instances.
    Reviewed-by: Dan Bode
    jeffmccune committed Dec 20, 2011
Commits on Dec 6, 2011
  1. Fix rspec dependency

    Without this patch, working with rspec-puppet in IRB fails when directly
    requiring the library:
        ruby-1.8.7-p334 :001 > require 'rspec-puppet'
        NameError: uninitialized constant RSpec
            from /Users/jeff/.rvm/gems/ruby-1.8.7-p334@puppet/gems/rspec-puppet-0.1.0/lib/rspec-puppet/matchers/create_generic.rb:1
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
            from /Users/jeff/.rvm/gems/ruby-1.8.7-p334@puppet/gems/rspec-puppet-0.1.0/lib/rspec-puppet/matchers.rb:1
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
            from /Users/jeff/.rvm/gems/ruby-1.8.7-p334@puppet/gems/rspec-puppet-0.1.0/lib/rspec-puppet.rb:2
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:58:in `gem_original_require'
            from /Users/jeff/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:58:in `require'
            from (irb):1
    This patch fixes the problem by requiring rspec directly from rspec-puppet.rb
    jeffmccune committed Dec 6, 2011
Commits on Nov 3, 2011
  1. Bump to 0.1.0

    rodjek committed Nov 3, 2011