-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting icon on uncovered lines #4
Comments
@Aharris88 Thanks for reporting. Seems there is a bug in computing the covered lines from statement map. I will look into this weekend. Pull requests are welcome :) |
I'm guessing the bug has to be here, but I'm not sure what the problem is. It looks good to me. |
Yes, that's right. I am working on it, should be fixed soon. |
@Aharris88 The issue should be fixed now. ref: https://github.com/gotwarlost/istanbul/blob/master/lib/object-utils.js#L51 |
That works. Thanks! 👍 |
For some reason, it is putting the icon next to any new lines I add, even if they aren't covered. I'm putting brand new functions in a file and never calling those functions. After
jest --coverage
runs, the plugin puts a green icon next to the lines in that function.I also checked out that file and the
s
key for that file said 0.The text was updated successfully, but these errors were encountered: