Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting icon on uncovered lines #4

Closed
agarrharr opened this issue Feb 10, 2017 · 5 comments
Closed

Putting icon on uncovered lines #4

agarrharr opened this issue Feb 10, 2017 · 5 comments

Comments

@agarrharr
Copy link

For some reason, it is putting the icon next to any new lines I add, even if they aren't covered. I'm putting brand new functions in a file and never calling those functions. After jest --coverage runs, the plugin puts a green icon next to the lines in that function.

I also checked out that file and the s key for that file said 0.

"/file/path.js": {
  "path": "/file/path.js",
  "statementMap": {
    ...
    "203":{"start":{"line":389,"column":14},"end":{"line":389,"column":15}}
    ...
  }
}
"s": {
  ...
  "203":0,
  ...
}
@ruanyl
Copy link
Owner

ruanyl commented Feb 13, 2017

@Aharris88 Thanks for reporting. Seems there is a bug in computing the covered lines from statement map. I will look into this weekend. Pull requests are welcome :)

@agarrharr
Copy link
Author

I'm guessing the bug has to be here, but I'm not sure what the problem is. It looks good to me.

@ruanyl
Copy link
Owner

ruanyl commented Feb 13, 2017

Yes, that's right. I am working on it, should be fixed soon.

@ruanyl
Copy link
Owner

ruanyl commented Feb 13, 2017

@agarrharr
Copy link
Author

That works. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants