New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove Project References Dialog #1276

Open
retailcoder opened this Issue Mar 30, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@retailcoder
Member

retailcoder commented Mar 30, 2016

The VBE's add reference dialog is painful - we could design a dialog that features a Search box so users can easily locate what they're looking for. We could also keep a list of "recent" references (saved in settings and updated automatically by simply using the dialog) so that users don't even need to search for them at all, and separate COM libraries from saved & opened VBA projects.

@retailcoder retailcoder added this to the v2.1 milestone Mar 30, 2016

@ThunderFrame

This comment has been minimized.

Show comment
Hide comment
@ThunderFrame

ThunderFrame Mar 30, 2016

Member

Referencing #950

Member

ThunderFrame commented Mar 30, 2016

Referencing #950

@ThunderFrame

This comment has been minimized.

Show comment
Hide comment
@ThunderFrame

ThunderFrame Mar 30, 2016

Member

Subtleties of the References Dialog: The References dialog lists referenced libraries, then other open projects and libraries referenced by other open projects (which is one way of discovering libraries that protected projects are referencing), and then registered libraries.

Member

ThunderFrame commented Mar 30, 2016

Subtleties of the References Dialog: The References dialog lists referenced libraries, then other open projects and libraries referenced by other open projects (which is one way of discovering libraries that protected projects are referencing), and then registered libraries.

@rossknudsen

This comment has been minimized.

Show comment
Hide comment
@rossknudsen

rossknudsen Jun 29, 2016

@Hosch250 @retailcoder Where do you think the menu command should be located? Off the root of the RD menu? Then I can probably give you a preview.

rossknudsen commented Jun 29, 2016

@Hosch250 @retailcoder Where do you think the menu command should be located? Off the root of the RD menu? Then I can probably give you a preview.

@ThunderFrame

This comment has been minimized.

Show comment
Hide comment
@ThunderFrame

ThunderFrame Mar 5, 2017

Member

@rossknudsen Did you have something that needed to be PR'ed?

Member

ThunderFrame commented Mar 5, 2017

@rossknudsen Did you have something that needed to be PR'ed?

@rossknudsen

This comment has been minimized.

Show comment
Hide comment
@rossknudsen

rossknudsen Mar 7, 2017

Hi @ThunderFrame. I've got some code which is not ready for PR at this stage. I have a dependency on a service which can allow the opening of application specific files, so they can be added as reference. E.g. in Word, I need to be able to open *.docx, *.docm, *.doc, *.dot etc. Similarly, Excel has a different set of files.

The built in references dialog allows you to reference these files, but it opens them in the background before it creates the reference.

Alternatively, I can create a PR for the references dialog without the ability to do this - i.e. only able to add references to dll/exe/tlb/ocx

rossknudsen commented Mar 7, 2017

Hi @ThunderFrame. I've got some code which is not ready for PR at this stage. I have a dependency on a service which can allow the opening of application specific files, so they can be added as reference. E.g. in Word, I need to be able to open *.docx, *.docm, *.doc, *.dot etc. Similarly, Excel has a different set of files.

The built in references dialog allows you to reference these files, but it opens them in the background before it creates the reference.

Alternatively, I can create a PR for the references dialog without the ability to do this - i.e. only able to add references to dll/exe/tlb/ocx

@retailcoder

This comment has been minimized.

Show comment
Hide comment
@retailcoder

retailcoder Mar 7, 2017

Member

@rossknudsen I still have your old PR in my fork. Haven't had a chance to work on it much for a while, but IIRC I was working on factoring out the dependency on VBProject so that project references would only ever get added/removed after the dialog is closed (and so nothing would happen if the dialog was cancelled, regardless of what happened while the dialog was open). You might want to pick it up from there, but it's probably over a thousand commits behind at this point.

Member

retailcoder commented Mar 7, 2017

@rossknudsen I still have your old PR in my fork. Haven't had a chance to work on it much for a while, but IIRC I was working on factoring out the dependency on VBProject so that project references would only ever get added/removed after the dialog is closed (and so nothing would happen if the dialog was cancelled, regardless of what happened while the dialog was open). You might want to pick it up from there, but it's probably over a thousand commits behind at this point.

@retailcoder

This comment has been minimized.

Show comment
Hide comment
@retailcoder

retailcoder Mar 7, 2017

Member

Dependencies on Kavod.ComReflection also need to be removed.

Member

retailcoder commented Mar 7, 2017

Dependencies on Kavod.ComReflection also need to be removed.

@rossknudsen

This comment has been minimized.

Show comment
Hide comment
@rossknudsen

rossknudsen Mar 7, 2017

Note, Kavod.ComReflection is a provided in a Nuget package. It provides the enumeration of available COM types. But you might mean that there is existing Rubberduck code that can replace this - I haven't checked.

From memory I modified the code so no changes are made until the dialog is closed, irrespective of the VBProject dependency. But you haven't got those changes because I'm pretty sure I haven't pushed them.

rossknudsen commented Mar 7, 2017

Note, Kavod.ComReflection is a provided in a Nuget package. It provides the enumeration of available COM types. But you might mean that there is existing Rubberduck code that can replace this - I haven't checked.

From memory I modified the code so no changes are made until the dialog is closed, irrespective of the VBProject dependency. But you haven't got those changes because I'm pretty sure I haven't pushed them.

@comintern

This comment has been minimized.

Show comment
Hide comment
@comintern

comintern Mar 7, 2017

Contributor

@rossknudsen - I haven't checked to see what functionality was being used from Kavod.ComReflection, but RD's version is in the Rubberduck.Parsing.ComReflection namespace.

Contributor

comintern commented Mar 7, 2017

@rossknudsen - I haven't checked to see what functionality was being used from Kavod.ComReflection, but RD's version is in the Rubberduck.Parsing.ComReflection namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment