Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate LibGit2Sharp v0.23/v0.24 #2497

Closed
Vogel612 opened this issue Jan 8, 2017 · 6 comments

Comments

5 participants
@Vogel612
Copy link
Member

commented Jan 8, 2017

On December 23 2016 LibGit2Sharp released v0.23

On June 22 2017 LibGit2Sharp v0.24

We should evaluate whether to update the dependency or carry on. If we update we should do so without destabilizing the Release

@retailcoder

This comment has been minimized.

Copy link
Member

commented Jan 8, 2017

That should be a pretty straightforward upgrade, in theory.

@daFreeMan

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2017

"In theory, there is no difference between practice and theory, in practice, however, there often is."

  • Someone other than me

@Vogel612 Vogel612 changed the title Evaluate LibGit2Sharp v0.23 Evaluate LibGit2Sharp v0.23/v0.24 Nov 15, 2017

@Vogel612 Vogel612 added this to TODO in CodeName: Cucumber Nov 18, 2017

@NelsonVides

This comment has been minimized.

Copy link
Member

commented Nov 20, 2017

Hey,
I'm a new guy in the project. Upgrading to v0.24 was actually the first thing I did when got my hands on Rubberduck, just out of curiosity. There were just a few of very easy to fix compile-issues: '.stage()' moves to the 'Commands' namespace, and '.commit()' now takes author and committer as two separate and both mandatory parameters. Then it compiled with no issues. As for actual unit test and running the new version on my every-day VBA life, I can't tell you much yet, but I haven't experiment any new crash.
I could help here, but please forgive me I'm just a hungry amateur. Somebody to help me to help? :)

@Hosch250

This comment has been minimized.

Copy link
Member

commented Nov 20, 2017

Awesome. I don't remember at the moment, but I thought there was a deeper problem here than just the API breaking things. Maybe @rubberduck203 would remember?

@Vogel612

This comment has been minimized.

Copy link
Member Author

commented Nov 20, 2017

TBH I wouldn't even care much about destabilizing Source Control at this point ... It's marked experimental, 0.24 could even bring some stability into it. As long as it doesn't obviously break the build, we can still stabilize it as the issues crop up.

@NelsonVides

This comment has been minimized.

Copy link
Member

commented Nov 20, 2017

So I've just sent you my changes on a pull request. Just a bunch of API differences. To be honest I find the repo.command(parameters) more intuitive than the command(repo,parameters). I'm acting on my repo object actually. But that's basically the main change from the guys at libgit.

@Vogel612 Vogel612 closed this in f398240 Nov 25, 2017

@Vogel612 Vogel612 moved this from TODO to Done in CodeName: Cucumber Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.