Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive `Replace function {x} with existing typed function` #5233

Closed
daFreeMan opened this issue Oct 18, 2019 · 0 comments · Fixed by #5234
Closed

False positive `Replace function {x} with existing typed function` #5233

daFreeMan opened this issue Oct 18, 2019 · 0 comments · Fixed by #5234
Labels
bug

Comments

@daFreeMan
Copy link
Contributor

@daFreeMan daFreeMan commented Oct 18, 2019

Rubberduck version information

Version 2.4.1.5097
OS: Microsoft Windows NT 10.0.15063.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.4873.1000
Host Executable: MSACCESS.EXE

Description
I'm told to replace Right with Right$, but the code clearly contains a Right$.

To Reproduce
Steps to reproduce the behavior:

  1. write code:
Private Property Let IWebDownloader_DestinationPath(ByVal inValue As String)
  If Right$(inValue, 1) = "\" Then
    this.DestinationPath = inValue
  Else
    this.DestinationPath = inValue & "\"
  End If
End Property
  1. Inspect
  2. Profit
  3. See error

Expected behavior
If there's already a typed function in use, don't suggest that I use one.

Screenshots
2019-10-18 11_42_53-Code Inspections

Logfile
RubberduckLog.txt

Additional context

  • The poor ducky even highlights the $! She (I assume she... Duga's a she, maybe I just got carried away?) just got confused.
  • This is definitely a somewhat recent regression - I've never seen this before. I don't know what version may have been the last one where this wasn't broken, however. Especially since I've installed 3 (or is it 4) so far this morning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.