New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Default Member Attribute #53

Open
retailcoder opened this Issue Nov 19, 2014 · 7 comments

Comments

Projects
None yet
4 participants
@retailcoder
Member

retailcoder commented Nov 19, 2014

Related: #52 (same prerequesites about importing/exporting code files)

This feature allows marking a class member as its "default member"; the feature should ensure there's only ever a single member marked as such.

Warn user when changing a class' default member, as this is a breaking change.

@retailcoder retailcoder added this to the Module & Procedure Attributes milestone Nov 19, 2014

@rubberduck203 rubberduck203 modified the milestone: Module & Procedure Attributes Feb 10, 2015

@retailcoder retailcoder added this to the Future Versions milestone Feb 10, 2015

@retailcoder

This comment has been minimized.

Member

retailcoder commented Sep 22, 2015

Same here; @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?

@rubberduck203

This comment has been minimized.

Member

rubberduck203 commented Sep 22, 2015

Yup. See #52

@retailcoder

This comment has been minimized.

Member

retailcoder commented Sep 22, 2015

@ckuhn203 Awesome! I'm making a new issue to coordinate these features.

@rubberduck203

This comment has been minimized.

Member

rubberduck203 commented Sep 22, 2015

Sounds like a plan!

@retailcoder retailcoder referenced this issue Sep 22, 2015

Open

Handle Procedure Attributes #786

0 of 4 tasks complete

@retailcoder retailcoder modified the milestones: Version 2.0, Future Versions Sep 22, 2015

@retailcoder retailcoder modified the milestones: v2.1, Version 2.0 Mar 18, 2016

@ThunderFrame

This comment has been minimized.

Member

ThunderFrame commented Apr 9, 2016

Oh, crap.

Member attributes are very sensitive to member declaration changes. Refactoring/editing a member declaration line is enough to blast the attribute into a thousand pieces of nothing.

Rubberduck needs to discover and monitor member attributes, and persist them if they're obliterated by user or refactoring actions.

@retailcoder

This comment has been minimized.

Member

retailcoder commented Apr 9, 2016

@ThunderFrame that could be considered a feature that.... fixes a VBE bug!

@retailcoder

This comment has been minimized.

Member

retailcoder commented Mar 13, 2017

Per linked issue, this will be implemented as an annotation:

'@MemberAttribute.VB_UserMemId(0)

Or:

'@DefaultMember

This specific attribute will also need an inspection, to ensure only one module member has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment