Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reorder parameters preview generation #4927

Merged
merged 4 commits into from Apr 26, 2019

Conversation

Projects
None yet
3 participants
@Vogel612
Copy link
Member

commented Apr 20, 2019

No description provided.

Vogel612 added some commits Apr 20, 2019

Fix reorder parameters preview
This also introduces an extension to the Accessibility enum to provide a codestring.
We're replacing the StringBuilder code with a more easily followed interpolated string as well
@codecov

This comment has been minimized.

Copy link

commented Apr 20, 2019

Codecov Report

Merging #4927 into next will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             next    #4927      +/-   ##
==========================================
- Coverage   64.53%   64.51%   -0.02%     
==========================================
  Files        1063     1069       +6     
  Lines       35584    35651      +67     
==========================================
+ Hits        22961    22997      +36     
- Misses      12623    12654      +31
Impacted Files Coverage Δ
...ings/RemoveParameters/RemoveParametersViewModel.cs 0% <0%> (ø) ⬆️
Rubberduck.Parsing/Symbols/Accessibility.cs 0% <0%> (ø)
...gs/ReorderParameters/ReorderParametersViewModel.cs 17.24% <0%> (+2.68%) ⬆️
Rubberduck.Core/Settings/Configuration.cs 66.67% <0%> (-33.33%) ⬇️
Rubberduck.Core/Settings/GeneralConfigProvider.cs 68.18% <0%> (-10.08%) ⬇️
....Parsing/Binding/ProcedurePointerBindingContext.cs 62.5% <0%> (-8.09%) ⬇️
Rubberduck.Parsing/Binding/TypeBindingContext.cs 81.25% <0%> (-4.96%) ⬇️
Rubberduck.Parsing/Symbols/IdentifierReference.cs 80.65% <0%> (-2.69%) ⬇️
...ubberduck.Parsing/Binding/DefaultBindingContext.cs 93.79% <0%> (-2.18%) ⬇️
.../VBA/ReferenceManagement/BoundExpressionVisitor.cs 99.2% <0%> (-0.8%) ⬇️
... and 71 more

retailcoder and others added some commits Apr 23, 2019

Add Doc-Comment to CodeString extension
Co-Authored-By: Vogel612 <Vogel612@users.noreply.github.com>

@Vogel612 Vogel612 merged commit 1655c1c into rubberduck-vba:next Apr 26, 2019

2 checks passed

codecov/project 64.51% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Vogel612 Vogel612 deleted the Vogel612:fix/reorder-parameters-preview branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.