Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language change exception #4929

Merged

Conversation

Projects
None yet
2 participants
@Vogel612
Copy link
Member

commented Apr 22, 2019

This PR introduces a component for search boxes, based on the in use code in Code Explorer and A/RRD.

On the side, this should also fix project recognition for Rubberduck.JunkDrawer as a new csproj-format project by introducing a TargetFramework.
Also there's some minor moving of files in the Controls folder, which is steadily growing.

Vogel612 added some commits Apr 22, 2019

Create SearchBox component
This component replaces the search boxes in CodeExplorer and Add/Remove References dialog.
It provides a vast simplification over the preexisting use of overriding a TextBox with a
Style defined in the resources section.

Also this commit moves Behaviours into their own solution folder, though no namespace adjustments
are performed.
Replace Search box in CodeExplorer and ARRD with component
This commit also fixes #4915 by virtue of changing how the text is set
@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #4929 into next will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             next    #4929      +/-   ##
==========================================
- Coverage   64.56%   64.47%   -0.09%     
==========================================
  Files        1065     1068       +3     
  Lines       35620    35672      +52     
==========================================
+ Hits        22997    22998       +1     
- Misses      12623    12674      +51
Impacted Files Coverage Δ
...duck.Core/UI/CodeExplorer/CodeExplorerControl.xaml 0% <ø> (ø) ⬆️
...I/Controls/Behavior/MenuItemButtonGroupBehavior.cs 0% <ø> (ø)
.../UI/Controls/Behavior/GroupItemExpandedBehavior.cs 0% <ø> (ø)
.../Controls/Behavior/BindableSelectedItemBehavior.cs 0% <ø> (ø)
Rubberduck.Core/UI/Controls/NumberPicker.xaml.cs 0% <ø> (ø) ⬆️
...ontrols/Behavior/FocusElementAfterClickBehavior.cs 0% <ø> (ø)
...AddRemoveReferences/AddRemoveReferencesWindow.xaml 0% <ø> (ø) ⬆️
Rubberduck.Core/UI/Controls/SearchBox.xaml 0% <0%> (ø)
Rubberduck.Core/UI/Controls/SearchBox.xaml.cs 0% <0%> (ø)
...ck.Core/UI/Controls/Behavior/ResetValueBehavior.cs 0% <0%> (ø)
... and 4 more

@retailcoder retailcoder merged commit 4d5420b into rubberduck-vba:next Apr 23, 2019

2 checks passed

codecov/project 64.47% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Vogel612 Vogel612 deleted the Vogel612:fix/language-change-exception branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.