Join GitHub today
Complete InspectionTestsBase incorporation #5226
Closes #5191. This PR incorporates InspectionTestsBase into the remaining inspection tests (except one - see below). The good news is that there is net reduction of nearly 4000 lines of inspection test code thanks to the
Other notes of interest:
I chose the latter approach. This was partly motivated by the fact that at several tests use the default Project and Module names as part of there expected value for comparison. The other reason is that there may be other test classes (now or in the future) that wish to use identifiers different than the defaults if for no other reason than to remove the possibility that changes to the default name would break its tests.
So, the following changes were made:
MDoerner left a comment
Tests have to be isolated from each other. So, they should never depend on mutable global state like a static writable property. This could change results based on the order they are executed and would make running them in parallel impossible.
Accordingly, I would like you revert the introduction of the two new static properties on
All comments and requested changes are addressed: