From fc95d2eddcb856dbca8f4271dc2189b36018eef2 Mon Sep 17 00:00:00 2001 From: GmausDev Date: Wed, 12 Oct 2022 23:44:23 +0200 Subject: [PATCH 1/3] Issue #5723 --- Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs b/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs index c5965218ad..5a371b29ba 100644 --- a/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs +++ b/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs @@ -4,8 +4,9 @@ public enum CodeInspectionType { RubberduckOpportunities, LanguageOpportunities, - MaintainabilityAndReadabilityIssues, + NamingAndConventionsIssues, CodeQualityIssues, Performance, + Uncategorized } } From 0433ab4af7bf2c9e8cb633b5cd90c218b60bd4eb Mon Sep 17 00:00:00 2001 From: GmausDev Date: Wed, 12 Oct 2022 23:54:47 +0200 Subject: [PATCH 2/3] Fix typo --- Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs b/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs index 5a371b29ba..c495bb7ada 100644 --- a/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs +++ b/Rubberduck.CodeAnalysis/Inspections/CodeInspectionType.cs @@ -7,6 +7,6 @@ public enum CodeInspectionType NamingAndConventionsIssues, CodeQualityIssues, Performance, - Uncategorized + Uncategorized, } } From 78e93825de1f1743b80d7abf4de10cc1245aa422 Mon Sep 17 00:00:00 2001 From: GmausDev Date: Thu, 13 Oct 2022 11:46:24 +0200 Subject: [PATCH 3/3] Renamed all references --- .../CodeInspectionDefaults.Designer.cs | 251 +++++++++--------- .../CodeInspectionDefaults.settings | 38 +-- Rubberduck.CodeAnalysis/app.config | 38 +-- .../WorkloadConfigs/Legacy/rubberduck.config | 8 +- .../Inspections/InspectionsUI.Designer.cs | 4 +- .../Inspections/InspectionsUI.cs.resx | 2 +- .../Inspections/InspectionsUI.de.resx | 2 +- .../Inspections/InspectionsUI.es.resx | 2 +- .../Inspections/InspectionsUI.fr.resx | 2 +- .../Inspections/InspectionsUI.it.resx | 2 +- .../Inspections/InspectionsUI.resx | 2 +- .../Settings/InspectionSettingsTests.cs | 4 +- 12 files changed, 176 insertions(+), 179 deletions(-) diff --git a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs index c6287dcf21..8a159534e8 100644 --- a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs +++ b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.Designer.cs @@ -1,10 +1,10 @@ //------------------------------------------------------------------------------ // -// This code was generated by a tool. -// Runtime Version:4.0.30319.42000 +// Este código fue generado por una herramienta. +// Versión de runtime:4.0.30319.42000 // -// Changes to this file may cause incorrect behavior and will be lost if -// the code is regenerated. +// Los cambios en este archivo podrían causar un comportamiento incorrecto y se perderán si +// se vuelve a generar el código. // //------------------------------------------------------------------------------ @@ -12,7 +12,7 @@ namespace Rubberduck.CodeAnalysis.Properties { [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()] - [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.8.1.0")] + [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.10.0.0")] public sealed partial class CodeInspectionDefaults : global::System.Configuration.ApplicationSettingsBase { private static CodeInspectionDefaults defaultInstance = ((CodeInspectionDefaults)(global::System.Configuration.ApplicationSettingsBase.Synchronized(new CodeInspectionDefaults()))); @@ -28,129 +28,126 @@ public static CodeInspectionDefaults Default { [global::System.Configuration.DefaultSettingValueAttribute("\r\n\r\n \r\n \r\n \r\n \r\n <" + - "CodeInspection Name=\"UnhandledOnErrorResumeNextInspection\" Severity=\"Warning\" In" + - "spectionType=\"CodeQualityIssues\" />\r\n \r\n <" + - "CodeInspection Name=\"ImplicitByRefModifierInspection\" Severity=\"Hint\" Inspection" + - "Type=\"CodeQualityIssues\" />\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n <" + - "CodeInspection Name=\"EmptyWhileWendBlockInspection\" Severity=\"Warning\" Inspectio" + - "nType=\"MaintainabilityAndReadabilityIssues\" />\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n " + - " \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n " + + " \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n " + + "\r\n \r\n \r\n \r\n \r\n \r\n \r\n true\r\n")] + " Name=\"IntegerDataTypeInspection\" Severity=\"Hint\" InspectionType=\"CodeQualityIss" + + "ues\" />\r\n \r\n \r\n " + + " \r\n " + + "\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n <" + + "CodeInspection Name=\"SelfAssignedDeclarationInspection\" Severity=\"Suggestion\" In" + + "spectionType=\"CodeQualityIssues\" />\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n <" + + "CodeInspection Name=\"AssignmentNotUsedInspection\" Severity=\"Suggestion\" Inspecti" + + "onType=\"CodeQualityIssues\" />\r\n " + + "\r\n \r\n \r\n " + + " \r\n \r\n \r\n \r\n true\r\n")] public global::Rubberduck.CodeAnalysis.Settings.CodeInspectionSettings CodeInspectionSettings { get { return ((global::Rubberduck.CodeAnalysis.Settings.CodeInspectionSettings)(this["CodeInspectionSettings"])); diff --git a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings index 922af23e11..2112d95f10 100644 --- a/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings +++ b/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings @@ -6,7 +6,7 @@ <?xml version="1.0" encoding="utf-16"?> <CodeInspectionSettings xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> <CodeInspections> - <CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="BooleanAssignedInIfElseInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="ObsoleteErrorSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="StopKeywordInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /> <CodeInspection Name="UnhandledOnErrorResumeNextInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> @@ -18,52 +18,52 @@ <CodeInspection Name="AttributeOutOfSyncInspection" Severity="Warning" InspectionType="RubberduckOpportunities" /> <CodeInspection Name="MissingAnnotationArgumentInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ModuleScopeDimKeywordInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="MultilineParameterInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="MultipleDeclarationsInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="ObsoleteCallStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ObsoleteCommentSyntaxInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ObsoleteLetStatementInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="OptionBaseInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="RedundantOptionInspection" Severity="Hint" InspectionType="LanguageOpportunities" /> <CodeInspection Name="OptionExplicitInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ProcedureCanBeWrittenAsFunctionInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ApplicationWorksheetFunctionInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /> <CodeInspection Name="AssignedByValParameterInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> - <CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="EmptyModuleInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="LineLabelNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="IntegerDataTypeInspection" Severity="Hint" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ShadowedDeclarationInspection" Severity="DoNotShow" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ConstantNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> - <CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> - <CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="DefaultProjectNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyCaseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyDoWhileBlockInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyElseBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyForEachBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyForLoopBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyIfBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EmptyWhileWendBlockInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> + <CodeInspection Name="EncapsulatePublicFieldInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="HostSpecificExpressionInspection" Severity="Warning" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="HungarianNotationInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="ImplicitActiveSheetReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ImplicitActiveWorkbookReferenceInspection" Severity="Warning" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ImplicitDefaultMemberAssignmentInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ImplicitPublicMemberInspection" Severity="Hint" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ImplicitVariantReturnTypeInspection" Severity="Hint" InspectionType="LanguageOpportunities" /> <CodeInspection Name="MemberNotOnInterfaceInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> - <CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="MoveFieldCloserToUsageInspection" Severity="Hint" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="NonReturningFunctionInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ObjectVariableNotSetInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ObsoleteGlobalInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> <CodeInspection Name="ObsoleteTypeHintInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="ParameterCanBeByValInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="ParameterNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="ProcedureNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="SelfAssignedDeclarationInspection" Severity="Suggestion" InspectionType="CodeQualityIssues" /> <CodeInspection Name="UnassignedVariableUsageInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="UndeclaredVariableInspection" Severity="Error" InspectionType="CodeQualityIssues" /> <CodeInspection Name="UntypedFunctionUsageInspection" Severity="Hint" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="UseMeaningfulNameInspection" Severity="Suggestion" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="VariableNotAssignedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="VariableNotUsedInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="VariableTypeNotDeclaredInspection" Severity="Warning" InspectionType="LanguageOpportunities" /> @@ -72,7 +72,7 @@ <CodeInspection Name="StepIsNotSpecifiedInspection" Severity="DoNotShow" InspectionType="LanguageOpportunities" /> <CodeInspection Name="StepOneIsRedundantInspection" Severity="Hint" InspectionType="LanguageOpportunities" /> <CodeInspection Name="SheetAccessedUsingStringInspection" Severity="Suggestion" InspectionType="LanguageOpportunities" /> - <CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="MaintainabilityAndReadabilityIssues" /> + <CodeInspection Name="ObsoleteMemberUsageInspection" Severity="Warning" InspectionType="NamingAndConventionsIssues" /> <CodeInspection Name="ObsoleteCallingConventionInspection" Severity="Warning" InspectionType="CodeQualityIssues" /> <CodeInspection Name="DuplicatedAnnotationInspection" Severity="Error" InspectionType="RubberduckOpportunities" /> <CodeInspection Name="ModuleWithoutFolderInspection" Severity="Suggestion" InspectionType="RubberduckOpportunities" /> diff --git a/Rubberduck.CodeAnalysis/app.config b/Rubberduck.CodeAnalysis/app.config index 09ad657d0a..56c52616a5 100644 --- a/Rubberduck.CodeAnalysis/app.config +++ b/Rubberduck.CodeAnalysis/app.config @@ -22,7 +22,7 @@ xmlns:xsd="http://www.w3.org/2001/XMLSchema"> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> - + + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> + InspectionType="NamingAndConventionsIssues" /> - - - - + + + + diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.Designer.cs b/Rubberduck.Resources/Inspections/InspectionsUI.Designer.cs index bf3a010bf7..8d134c95b4 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.Designer.cs +++ b/Rubberduck.Resources/Inspections/InspectionsUI.Designer.cs @@ -99,9 +99,9 @@ public static string CodeInspectionSettings_LanguageOpportunities { /// /// Looks up a localized string similar to Maintainability and Readability Issues. /// - public static string CodeInspectionSettings_MaintainabilityAndReadabilityIssues { + public static string CodeInspectionSettings_NamingAndConventionsIssues { get { - return ResourceManager.GetString("CodeInspectionSettings_MaintainabilityAndReadabilityIssues", resourceCulture); + return ResourceManager.GetString("CodeInspectionSettings_NamingAndConventionsIssues", resourceCulture); } } diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.cs.resx b/Rubberduck.Resources/Inspections/InspectionsUI.cs.resx index 5b7d62ef35..14290c35fa 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.cs.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.cs.resx @@ -150,7 +150,7 @@ Příležitosti Jazyka - + Problémy Udržovatelnosti a Čitelnosti diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.de.resx b/Rubberduck.Resources/Inspections/InspectionsUI.de.resx index c73edfe2be..3782334e69 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.de.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.de.resx @@ -153,7 +153,7 @@ Nicht Anzeigen - + Wartbarkeits- und Leserlichkeitsprobleme diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.es.resx b/Rubberduck.Resources/Inspections/InspectionsUI.es.resx index c30f96a749..203c121ba5 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.es.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.es.resx @@ -150,7 +150,7 @@ Oportunidades de lenguaje - + Problemas de mantenibilidad y legibilidad diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.fr.resx b/Rubberduck.Resources/Inspections/InspectionsUI.fr.resx index 59d4dfe8ea..524d776a2f 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.fr.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.fr.resx @@ -147,7 +147,7 @@ Ne pas afficher - + Lecture et facilité d'entretient diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.it.resx b/Rubberduck.Resources/Inspections/InspectionsUI.it.resx index 6e6a973cb9..7b42b9df20 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.it.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.it.resx @@ -156,7 +156,7 @@ Opportunità del linguaggio - + Problemi di manutenibilità e leggibilità diff --git a/Rubberduck.Resources/Inspections/InspectionsUI.resx b/Rubberduck.Resources/Inspections/InspectionsUI.resx index 73d1c8ca9f..84faeedfde 100644 --- a/Rubberduck.Resources/Inspections/InspectionsUI.resx +++ b/Rubberduck.Resources/Inspections/InspectionsUI.resx @@ -150,7 +150,7 @@ Language Opportunities - + Maintainability and Readability Issues diff --git a/RubberduckTests/Settings/InspectionSettingsTests.cs b/RubberduckTests/Settings/InspectionSettingsTests.cs index 4f6fae5afa..5bc3d8fd8c 100644 --- a/RubberduckTests/Settings/InspectionSettingsTests.cs +++ b/RubberduckTests/Settings/InspectionSettingsTests.cs @@ -19,7 +19,7 @@ private Configuration GetDefaultConfig() { new CodeInspectionSetting("DoNotShowInspection", "Do not show me", CodeInspectionType.LanguageOpportunities, CodeInspectionSeverity.DoNotShow), new CodeInspectionSetting("HintInspection", "I'm a hint", CodeInspectionType.LanguageOpportunities, CodeInspectionSeverity.Hint), - new CodeInspectionSetting("SuggestionInspection", "I'm a suggestion", CodeInspectionType.MaintainabilityAndReadabilityIssues, CodeInspectionSeverity.Suggestion), + new CodeInspectionSetting("SuggestionInspection", "I'm a suggestion", CodeInspectionType.NamingAndConventionsIssues, CodeInspectionSeverity.Suggestion), new CodeInspectionSetting("WarningInspection", "I'm a warning", CodeInspectionType.CodeQualityIssues), new CodeInspectionSetting("NondefaultSeverityInspection", "I do not have my original severity", CodeInspectionType.LanguageOpportunities,CodeInspectionSeverity.DoNotShow), new CodeInspectionSetting("ErrorInspection", "FIX ME!", CodeInspectionType.CodeQualityIssues, CodeInspectionSeverity.Error) @@ -39,7 +39,7 @@ private Configuration GetNondefaultConfig() { new CodeInspectionSetting("DoNotShowInspection", "Do not show me", CodeInspectionType.LanguageOpportunities), new CodeInspectionSetting("HintInspection", "I'm a hint", CodeInspectionType.LanguageOpportunities, CodeInspectionSeverity.Suggestion), - new CodeInspectionSetting("SuggestionInspection", "I'm a suggestion", CodeInspectionType.MaintainabilityAndReadabilityIssues, CodeInspectionSeverity.Hint), + new CodeInspectionSetting("SuggestionInspection", "I'm a suggestion", CodeInspectionType.NamingAndConventionsIssues, CodeInspectionSeverity.Hint), new CodeInspectionSetting("WarningInspection", "I'm a warning", CodeInspectionType.CodeQualityIssues, CodeInspectionSeverity.Error), new CodeInspectionSetting("NondefaultSeverityInspection", "I do not have my original severity", CodeInspectionType.LanguageOpportunities, CodeInspectionSeverity.Error), new CodeInspectionSetting("ErrorInspection", "FIX ME!", CodeInspectionType.CodeQualityIssues, CodeInspectionSeverity.DoNotShow)