Skip to content

Added ability to equip the 'New Item' in the Item Compare screen. fixes #34 #53

merged 3 commits into from Jul 9, 2012

2 participants

smerchek commented Jul 5, 2012

Couple things to note about the design here.

I put the button on the New Item next to reset because it feels like you are really performing the action on the New Item. This simplifies the button, because it can merely say 'Equip' rather than 'Equip New Item' or something like that.

I also decided that it makes sense to disable the button if 'New Item' has no changes (it is in the default state). This will help accidentally clicking Equip twice and overwriting your equipped item. I think that this will be good enough to prevent people from making mistakes, but I'm open to also having a dialog to confirm. However, dialogs can often be annoying, so I'd like it to not need one. That said, we might want to move it away from 'Reset' a little more.

Let me know what you think of these changes.

smerchek commented Jul 5, 2012

Fixes #34

@rubensayshi rubensayshi merged commit 93a5ec4 into rubensayshi:master Jul 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.