Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Revert "Close handles opened with dlopen()"

This reverts commit 699b03a.

This was causing the profiler tooling extension to be unloaded
so that running the profiler with eg:

  rbx -Xprofile -e 'p 1'

would cause an EXC_BAD_ACCESS on OS X Maverics at least.

Generally, we don't want to dlclose() a library that we loaded
and intend to use. We may address this by passing RTDL_NODELETE
to dlopen(), but that mode flag is not universally supported and
was added later. If we don't intend to unload the library, there's
no reason to dlclose() it before process exit.
  • Loading branch information...
commit 56d2edb4eaf1080b5c02dbda5c4214fd44bc4a43 1 parent 399deb8
@brixen brixen authored
Showing with 0 additions and 2 deletions.
  1. +0 −1  vm/builtin/system.cpp
  2. +0 −1  vm/environment.cpp
View
1  vm/builtin/system.cpp
@@ -681,7 +681,6 @@ namespace rubinius {
}
}
- dlclose(handle);
return Tuple::from(state, 1, cTrue);
}
View
1  vm/environment.cpp
@@ -744,7 +744,6 @@ namespace rubinius {
std::cerr << "Tool '" << path << "' reported failure to init.\n";
}
}
- dlclose(handle);
}
std::string Environment::executable_name() {
Please sign in to comment.
Something went wrong with that request. Please try again.