Merge branch 'master' into 2.2

* master:
  Fixes to assist building Rubinius under Alpine Linux (with musl).
  Changed "of the issue" to "if the issue"
  Contributing notes on version managers/releases
  Expand $PID in Metrics filename.
  Clean up log output of serial_debug/ic_debug
  Specify `superclass` in respect to `prepend`
  Fix correction to documentation for OnStack class.
  Fixed typ in the OnStack class
  Log class names for invalid ivars_ references
  Add a C-API "rb_hash_clear"
  Fix Range#bsearch for matching end value in find-minimum mode
  Fix String#split with 0 limit. Fixes #3474
  Add a String#split spec with 0 limit

Author: tak1n

CONTRIBUTING.md

@@ -27,6 +27,27 @@ Gist:
 These two files contain the output of the compilation process and the various
 configuration options used (e.g. compiler options).
 
+### Version Managers
+
+We can *not* help you with any issues that might be caused by a Ruby version
+manager. In the event of any issues please try building from source instead to
+see if the issue is caused by Rubinius itself or your version manager of choice.
+
+Issues involving version managers will be closed if they can either not be
+reproduced when building from source, or when the original report makes no
+mention about the author having tried building from source.
+
+Note that this only applies to the installation procedure. Problems with the
+runtime can of course still be reported, even when using a version manager.
+
+### Rubinius Versions
+
+Rubinius releases quite often, at least more often than most other
+implementations. As such we ask users to try out the latest version prior to
+reporting an issue. This ensures we don't have to start digging through the
+code, only to find out the problem has already been resolved in a more recent
+release.
+
 ### Running Specs
 
 MSpec provides several different scripts to run the specs under different

kernel/common/range.rb

@@ -51,47 +51,47 @@ def bsearch
 
     last_true = nil
 
-    if max < 0 and min < 0
-      value = min + (max - min) / 2
-    elsif min < -max
-      value = -((-1 - min - max) / 2 + 1)
-    else
-      value = (min + max) / 2
-    end
-
-    while min < max
-      x = yield value
+    seeker = Proc.new do |current|
+      x = yield current
 
-      return value if x == 0
+      return current if x == 0
 
       case x
       when Numeric
         if x > 0
-          min = value + 1
+          min = current + 1
         else
-          max = value
+          max = current
         end
       when true
-        last_true = value
-        max = value
+        last_true = current
+        max = current
       when false, nil
-        min = value + 1
+        min = current + 1
       else
         raise TypeError, "Range#bsearch block must return Numeric or boolean"
       end
+    end
 
+    while min < max
       if max < 0 and min < 0
-        value = min + (max - min) / 2
+        mid = min + (max - min) / 2
       elsif min < -max
-        value = -((-1 - min - max) / 2 + 1)
+        mid = -((-1 - min - max) / 2 + 1)
       else
-        value = (min + max) / 2
-      end
+        mid = (min + max) / 2
+      end      
+      
+      seeker.call mid
+    end
+    
+    if min == max
+      seeker.call min
     end
 
     if min < max
-      return @begin if value == start
-      return @begin.kind_of?(Float) ? value.to_f : value
+      return @begin if mid == start
+      return @begin.kind_of?(Float) ? mid.to_f : mid
     end
 
     if last_true

kernel/common/splitter.rb

@@ -32,7 +32,9 @@ def self.split(string, pattern, limit)
           return [string.dup] if limit == 1
           limited = true
         else
-          tail_empty = true
+          if limit < 0
+            tail_empty = true
+          end
           limited = false
         end
       end

rakelib/platform.rake

@@ -752,7 +752,7 @@ file 'runtime/platform.conf' => deps do |task|
 
     Rubinius::FFI::Generators::Constants.new 'rbx.platform.signal' do |cg|
       cg.include 'signal.h'
-      unless BUILD_CONFIG[:windows]
+      unless BUILD_CONFIG[:windows] or RUBY_PLATFORM.match(/linux-musl$/)
         cg.include 'sys/signal.h'
       end
 

spec/ruby/core/module/prepend_spec.rb

@@ -6,6 +6,10 @@
     Module.should have_public_instance_method(:prepend, true)
   end
 
+  it "does not affect the superclass" do
+    Class.new { prepend Module.new }.superclass.should == Object
+  end
+
   it "calls #prepend_features(self) in reversed order on each module" do
     ScratchPad.record []
 

spec/ruby/core/string/split_spec.rb

@@ -103,6 +103,12 @@
     "a\x00a b".split(' ').should == ["a\x00a", "b"]
   end
 
+  describe "when limit is zero" do
+    it "ignores leading and continuous whitespace when string is a single space" do
+      " now's  the time  ".split(' ', 0).should == ["now's", "the", "time"]
+    end
+  end
+
   it "splits between characters when its argument is an empty string" do
     "hi!".split("").should == ["h", "i", "!"]
     "hi!".split("", -1).should == ["h", "i", "!", ""]

spec/ruby/optional/capi/ext/hash_spec.c

@@ -40,6 +40,12 @@ VALUE hash_spec_rb_hash_aset(VALUE self, VALUE hash, VALUE key, VALUE val) {
 }
 #endif
 
+#ifdef HAVE_RB_HASH_CLEAR
+VALUE hash_spec_rb_hash_clear(VALUE self, VALUE hash) {
+  return rb_hash_clear(hash);
+}
+#endif
+
 #ifdef HAVE_RB_HASH_DELETE
 VALUE hash_spec_rb_hash_delete(VALUE self, VALUE hash, VALUE key) {
   return rb_hash_delete(hash, key);
@@ -148,6 +154,10 @@ void Init_hash_spec() {
   rb_define_method(cls, "rb_hash_aset", hash_spec_rb_hash_aset, 3);
 #endif
 
+#ifdef HAVE_RB_HASH_CLEAR
+  rb_define_method(cls, "rb_hash_clear", hash_spec_rb_hash_clear, 1);
+#endif
+
 #ifdef HAVE_RB_HASH_DELETE
   rb_define_method(cls, "rb_hash_delete", hash_spec_rb_hash_delete, 2);
 #endif

spec/ruby/optional/capi/ext/rubyspec.h

@@ -322,6 +322,7 @@
 #define HAVE_RB_HASH_FREEZE                1
 #define HAVE_RB_HASH_AREF                  1
 #define HAVE_RB_HASH_ASET                  1
+#define HAVE_RB_HASH_CLEAR                 1
 #define HAVE_RB_HASH_DELETE                1
 #define HAVE_RB_HASH_DELETE_IF             1
 #define HAVE_RB_HASH_FOREACH               1

spec/ruby/optional/capi/hash_spec.rb

@@ -91,6 +91,14 @@
     end
   end
 
+  describe "rb_hash_clear" do
+    it "returns self that cleared keys and values" do
+      hsh = { :key => 'value' }
+      @s.rb_hash_clear(hsh).should equal(hsh)
+      hsh.should == {}
+    end
+  end
+
   describe "rb_hash_delete" do
     it "removes the key and returns the value" do
       hsh = {:chunky => 'bacon'}