Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

The -Xthread.debug option doesn't do anything #2923

Closed
southerngs opened this Issue Feb 5, 2014 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

southerngs commented Feb 5, 2014

It looks like the -Xthread.debug option doesn't do anything.

It also looks like the threading messages are controlled by the cDebugThreading variable which is a const set in oop.hpp.

I'm wondering if cDebugThreading was intentionally set as a const for performance reasons and if the -Xthread.debug option should be removed from the help message. Or if the -Xthread.debug should set the value of cDebugThreading.

Contributor

southerngs commented Feb 6, 2014

I see I was wrong in thinking that -Xthread.debug doesn't do anything. I see it's used in two places in oop.cpp. I also see that cDebugThreading needs to be const since it's defined in the oop.hpp header file.

But I'm still not sure why most of the debug messages are controlled by cDebugThreading rather than a runtime option.

Owner

dbussink commented Feb 6, 2014

So the reason is that having a dynamic check there would mean quite an overhead for all the locking code. We probably should also guard the cases we have now with cDebugThreading and remove -Xthread.debug.

Contributor

southerngs commented Feb 6, 2014

That makes sense. I submitted a pull request to remove the -Xthread.debug option.

Owner

YorickPeterse commented Feb 7, 2014

Solved in #2924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment