Added more specs #1038

Merged
merged 20 commits into from Feb 13, 2013

Conversation

Projects
None yet
5 participants
Contributor

flavio commented Jun 21, 2011

Improve rubyspec coverage.

brixen was assigned Jun 21, 2011

Contributor

headius commented Jun 22, 2011

A question: should specs be committed to Rubinius or to RubySpec? I would have thought the latter, even though Rubinius's copy gets periodically merged back. Commits directly would then be immediately accessible by all implementations, rather than waiting for the merge.

Contributor

flavio commented Jun 22, 2011

Good question. I'm new to the rubinius project, so I'm eager to know what is the preferred approach.

Contributor

flavio commented Jun 22, 2011

Stupid typo, it's not 'core' refactoring but 'code'. Excuse me...

@flavio flavio Core refactoring: follow rubyspec coding guidelines
Put utility class into a special module in order to avoid name clashes.
251b9f5
Owner

brixen commented Jun 22, 2011

This is the procedure we request people follow when writing specs for making changes to Rubinius http://rubini.us/doc/en/specs/.

Commits can be submitted to RubySpec directly also, but we expect to see passing specs or CI tags removed for commits to Rubinius and the above procedure has the least friction for all parties.

@charlie, if you're concerned about the availability of the specs in RubySpec, request that I sync them if I'm behind on that.

Contributor

headius commented Jun 22, 2011

In this case, it seems the specs are just being added to fill out RubySpec, so perhaps it's better to just commit to RubySpec.

I understand that fixes to Rubinius, when accompanied by spec changes, will go into Rubinius as two commits with the spec change later merged back to RubySpec. That's fine. But spec additions/changes separate from Rubinius work have always gone into RubySpec, and I think that should continue. Agreed?

Contributor

flavio commented Jul 6, 2011

As discussed on irc I'll fix the File::Stat specs as soon as @brixen commits an example.

This pull request passes (merged 37a12ae into d6ac366).

This pull request passes (merged 0de4dd8 into 7f24eb5).

This pull request passes (merged 4e6f815 into c4fe2ec).

Peeja commented Nov 21, 2012

A wild triage fairy appears!

@flavio, are you still waiting on @brixen's example?

Owner

brixen commented Nov 21, 2012

@Peeja I'll be adding some shortly.

Contributor

flavio commented Nov 21, 2012

Awesome, thanks!
On Nov 21, 2012 9:09 PM, "Brian Ford" notifications@github.com wrote:

@Peeja https://github.com/Peeja I'll be adding some shortly.


Reply to this email directly or view it on GitHubhttps://github.com/rubinius/rubinius/pull/1038#issuecomment-10612261.

@brixen brixen added a commit that referenced this pull request Feb 13, 2013

@brixen brixen Merge pull request #1038 from flavio/master
Added more specs
5c34664

@brixen brixen merged commit 5c34664 into rubinius:master Feb 13, 2013

@brixen brixen added a commit that referenced this pull request Dec 11, 2014

@brixen brixen Updated rubygems to 2.4.5.
RubyGems 2.4.5 installed

=== 2.4.5 / 2014-12-03

Bug fixes:

* Improved speed of requiring gems.  (Around 25% for a 60 gem test).  Pull
  request #1060 by unak.
* RubyGems no longer attempts to look up gems remotely with the --local flag.
  Pull request #1084 by Jeremy Evans.
* Executable stubs use the correct gem version when RUBYGEMS_GEMDEPS is
  active.  Issue #1072 by Michael Kaiser-Nyman.
* Fixed handling of pinned gems in lockfiles with versions.  Issue #1078 by
  Ian Ker-Seymer.
* Fixed handling of git@example:gem.git URIs.  Issue #1054 by Mogutan Mogu.
* Fixed handling of platforms retrieved from the dependencies API.  Issue
  #1058 and patch suggestion by tux-mind.
* RubyGems now suggests a copy-pasteable `gem pristine` command when
  extensions are missing.  Pull request #1057 by Shannon Skipper.
* Improved errors for long file names when packaging.  Pull request #1016 by
  Piotrek Bator.
* `gem pristine` now skips gems cannot be found remotely.  Pull request #1064
  by Tuomas Kareinen.
* `gem pristine` now caches gems to the proper directory.  Pull request #1064
  by Tuomas Kareinen.
* `gem pristine` now skips bundled gems properly.  Pull request #1064 by
  Tuomas Kareinen.
* Improved interoperability of Vagrant with RubyGems.  Pull request #1057 by
  Vít Ondruch.
* Renamed CONTRIBUTING to CONTRIBUTING.rdoc to allow markup.  Pull request
  #1090 by Roberto Miranda.
* Switched from #partition to #reject as only one collection is used.  Pull
  request #1074 by Tuomas Kareinen.
* Fixed installation of gems on systems using memory-mapped files.  Pull
  request #1038 by Justin Li.
* Fixed bug in Gem::Text#min3 where `a == b < c`.  Pull request #1026 by
  fortissimo1997.
* Fixed uninitialized variable warning in BasicSpecification.  Pull request
  #1019 by Piotr Szotkowski.
* Removed unneeded exception handling for cyclic dependencies.  Pull request
  #1043 by Jens Wille.
* Fixed grouped expression warning.  Pull request #1081 by André Arko.
* Fixed handling of platforms when writing lockfiles.

=== 2.4.4 / 2014-11-12
891d9dc

@brixen brixen added a commit that referenced this pull request Apr 18, 2015

@brixen brixen Updated RubyGems to 2.4.6.
RubyGems 2.4.6 installed

=== 2.4.6 / 2014-02-05

Bug fixes:

* Fixed resolving gems with both upper and lower requirement boundaries.
  Issue #1141 by Jakub Jirutka.
* Moved extension directory after require_paths to fix missing constant bugs
  in some gems with C extensions.  Issue #784 by André Arko, pull request
  #1137 by Barry Allard.
* Use Gem::Dependency#requirement when adding a dependency to an existing
  dependency instance.  Pull request #1101 by Josh Cheek.
* Fixed warning of shadowed local variable in Gem::Specification.  Pull request
  #1109 by Rohit Arondekar
* Gem::Requirement should always sort requirements before coercion to Hash.
  Pull request #1139 by Eito Katagiri.
* The `gem open` command should change the current working directory before
  opening the editor.  Pull request #1142 by Alex Wood.
* Ensure quotes are stripped from the Windows launcher script used to install
  gems.  Pull request #1115 by Youngjun Song.
* Fixed errors when writing to NFS to to 0444 files.  Issue #1161 by Emmanuel
  Hadoux.
* Removed dead code in Gem::StreamUI.  Pull request #1117 by mediaslave24.
* Fixed typos.  Pull request #1096 by hakeda.
* Relaxed CMake dependency for RHEL 6 and CentOS 6.  Pull request #1124 by Vít
  Ondruch.
* Relaxed Psych dependency.  Pull request #1128 by Vít Ondruch.

=== 2.4.5 / 2014-12-03

Bug fixes:

* Improved speed of requiring gems.  (Around 25% for a 60 gem test).  Pull
  request #1060 by unak.
* RubyGems no longer attempts to look up gems remotely with the --local flag.
  Pull request #1084 by Jeremy Evans.
* Executable stubs use the correct gem version when RUBYGEMS_GEMDEPS is
  active.  Issue #1072 by Michael Kaiser-Nyman.
* Fixed handling of pinned gems in lockfiles with versions.  Issue #1078 by
  Ian Ker-Seymer.
* Fixed handling of git@example:gem.git URIs.  Issue #1054 by Mogutan Mogu.
* Fixed handling of platforms retrieved from the dependencies API.  Issue
  #1058 and patch suggestion by tux-mind.
* RubyGems now suggests a copy-pasteable `gem pristine` command when
  extensions are missing.  Pull request #1057 by Shannon Skipper.
* Improved errors for long file names when packaging.  Pull request #1016 by
  Piotrek Bator.
* `gem pristine` now skips gems cannot be found remotely.  Pull request #1064
  by Tuomas Kareinen.
* `gem pristine` now caches gems to the proper directory.  Pull request #1064
  by Tuomas Kareinen.
* `gem pristine` now skips bundled gems properly.  Pull request #1064 by
  Tuomas Kareinen.
* Improved interoperability of Vagrant with RubyGems.  Pull request #1057 by
  Vít Ondruch.
* Renamed CONTRIBUTING to CONTRIBUTING.rdoc to allow markup.  Pull request
  #1090 by Roberto Miranda.
* Switched from #partition to #reject as only one collection is used.  Pull
  request #1074 by Tuomas Kareinen.
* Fixed installation of gems on systems using memory-mapped files.  Pull
  request #1038 by Justin Li.
* Fixed bug in Gem::Text#min3 where `a == b < c`.  Pull request #1026 by
  fortissimo1997.
* Fixed uninitialized variable warning in BasicSpecification.  Pull request
  #1019 by Piotr Szotkowski.
* Removed unneeded exception handling for cyclic dependencies.  Pull request
  #1043 by Jens Wille.
* Fixed grouped expression warning.  Pull request #1081 by André Arko.
* Fixed handling of platforms when writing lockfiles.

------------------------------------------------------------------------------
c3b4f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment