Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Running spec/ruby/core for 1.8 fails #1652

Closed
wants to merge 1 commit into from

4 participants

@michalbugno

I'm new to Rubinius and not sure if I reproduced it ok, but when I tried to run ./bin/mspec ci -T -X18 spec/ruby/core/ (which I believe is a subset of specs which should work for rubinius 1.8.X) I got two errors:

  1. Syntax on :! : MRI allows it and in RBX you have to :"!" -- this looks like a bug?
  2. BasicObject fixtures which should not load in 1.8 (no BO there)
@michalbugno

The :! is not a bug actually, MRI1.9 handles it but MRI1.8 does not. Still the BasicObject should not load for 1.8

Michal Bugno BasicObject fixtures should not load in 1.8
Fix to :! parser error in BasicObject specs
adf9670
@jfirebaugh
Collaborator

The BasicObject specs are normally excluded on 1.8 via rbx.1.8.mspec. @brixen, is it intended that mspec command line arguments override any excludes in the .mspec file?

@travisbot

This pull request passes (merged adf9670 into f4beee0).

@brixen
Owner

If you want to run all the specs under spec/ruby/core, use the :core psuedo dir that mspec provides.

E.g. bin/mspec ci -T -X18 :core

@brixen brixen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 11, 2012
  1. BasicObject fixtures should not load in 1.8

    Michal Bugno authored
    Fix to :! parser error in BasicObject specs
This page is out of date. Refresh to see the latest.
View
16 spec/ruby/core/basicobject/fixtures/common.rb
@@ -1,9 +1,13 @@
-module BasicObjectSpecs
- class BOSubclass < BasicObject
- def self.kernel_defined?
- defined?(Kernel)
- end
+ruby_version_is "1.9" do
+
+ module BasicObjectSpecs
+ class BOSubclass < BasicObject
+ def self.kernel_defined?
+ defined?(Kernel)
+ end
- include ::Kernel
+ include ::Kernel
+ end
end
+
end
View
2  spec/ruby/core/basicobject/not_spec.rb
@@ -3,7 +3,7 @@
ruby_version_is "1.9" do
describe "BasicObject#!" do
it "is a public instance method" do
- BasicObject.should have_public_instance_method(:!)
+ BasicObject.should have_public_instance_method(:"!")
end
it "returns false" do
Something went wrong with that request. Please try again.