Skip to content

Math::gamma fix and spec improvements #1700

Merged
merged 13 commits into from May 3, 2012

3 participants

@r-stu31
r-stu31 commented May 3, 2012

This fixes a bug in Rubinius implementation of Math::gamma for integral arguments in range 24..171 and improves Math::gamma specs.

@travisbot

This pull request fails (merged 724f16d into c4fe2ec).

@r-stu31
r-stu31 commented May 3, 2012

Please wait with the pull, I'll fix the errors reported by travisbot.

@travisbot

This pull request fails (merged 2d5a833 into c4fe2ec).

@travisbot

This pull request passes (merged e2ca816 into c4fe2ec).

@travisbot

This pull request passes (merged 8bade74 into c4fe2ec).

@travisbot

This pull request passes (merged 013f7bd into c4fe2ec).

@r-stu31
r-stu31 commented May 3, 2012

I think I'm done. :)
Besides the original issue, I've included the fix and test case for Math::gamma(-0.0) == -Float::INFINITY, thanks brixen for the tip how to do it neatly.

Please pull.

@brixen brixen merged commit a0d398a into rubinius:master May 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.