Cleanup File#identical?: use a shared implementation which fixes 1.8 #1754

Merged
merged 3 commits into from Jun 9, 2012

Projects

None yet

4 participants

@eregon
Contributor
eregon commented May 28, 2012

It was failing if arguments were not Strings:

TypeError:
      Tried to use object of type PackedObject (49) as type String (56)

I attach a failing spec solved with this change.

eregon added some commits May 28, 2012
@eregon eregon Cleanup File#identical?: use a shared implementation which fixes 1.8
It was failing if arguments were not Strings:
TypeError:
      Tried to use object of type PackedObject (49) as type String (56)
1b151fe
@eregon eregon Add a spec for File#identical? in 1.8 mode for non-String arguments 075cb50
@travisbot

This pull request passes (merged 3c83a339 into 0672a14).

@travisbot

This pull request passes (merged e968b96a into 0672a14).

@travisbot

This pull request passes (merged 1b151fe into 0672a14).

@SJD
SJD commented May 29, 2012

Shouldn't a function like this check the device too?

@eregon
Contributor
eregon commented May 29, 2012

You're right, I added it, thanks for noticing.
This seems to be the only use comparing inode numbers without checking the device.

@travisbot

This pull request passes (merged 291baa5 into 0672a14).

@dbussink dbussink merged commit bea4bbe into rubinius:master Jun 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment