Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ruby 1.9: implement correct behaviour of File.lchmod #1827

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

flavio commented Jul 24, 2012

File.respond_to?(:lchmod) should return false if the platform does not support lchmod.

File.lchmod should raise a NotImplementedError if the platform does not support the lchmod.

This commit fixes some spec failing when ruby 1.9 is enabled.

This is the first time I touch vm internals, I acted mimicking the existing code. I hope I didn't forget/screw up something.

flavio added some commits Jul 24, 2012

Fix lchmod spec
Use the right syntax inside of the spec file, previously an
ArgumentError was raised.
Ruby 1.9: implement correct behaviour of File.lchmod
File.respond_to?(:lchmod) should return false if the platform does not
support lchmod.

File.lchmod should raise a NotImplementedError if the platform does not
support the lchmod.

This commit fixes some spec failing when ruby 1.9 is enabled.
Owner

dbussink commented Jul 24, 2012

We don't implement chmod / lchmod inside the VM as primitives but with FFI. Changing this should therefore use FFI like we already do at the moment.

This pull request passes (merged da3254b into 56a5b44).

Owner

dbussink commented Jul 24, 2012

Per our discussion on IRC, I'm closing this one. If you need any help / want to take other things don't be afraid to ask in #rubinius if you're not sure on how tackle certain issues.

@dbussink dbussink closed this Jul 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment