Fixes clang[++] build failure on Apple Clang 4.0. #1849

Merged
merged 1 commit into from Aug 7, 2012

Projects

None yet

3 participants

@mysteriouspants
Contributor

This fixes a build failure on Apple Mac OS X 10.8 "Mountain Lion" when building with Apple Clang 4.0 (from Xcode). (See https://gist.github.com/6d03ae640101d96d6193).

I'm not too knowledgable about hacking build scripts, so feel free to tell me to change something.

Thanks!

@travisbot

This pull request fails (merged 16ab9cba into 422359a).

@travisbot

This pull request passes (merged 15ccabf7 into 422359a).

@dbussink
Member
dbussink commented Aug 7, 2012

Could you change it to just always remove it, so also in the initial commit you made? It should be fine to do it all in a single commit and force push that for the pull request, so we can merge it all nicely in a single commit.

@mysteriouspants
Contributor

& done. Thanks!

@dbussink
Member
dbussink commented Aug 7, 2012

Looks like it's also in more places:

https://gist.github.com/c0d549115fe03a2007ad

@mysteriouspants
Contributor

Those are not compiled against rbx itself, and so they aren't compiled with -Werror, so they don't halt the build. I think purging that flag entirely would be appropriate for a separate pull request. :)

@dbussink
Member
dbussink commented Aug 7, 2012

Nah, if we remove it, we might as well be consistent about it.

@mysteriouspants
Contributor

Then I'll go git commit --amend and butcher the rest of the stuff :P

@travisbot

This pull request passes (merged eb44c770 into 65b5f2c).

@dbussink dbussink merged commit d47f143 into rubinius:master Aug 7, 2012

1 check was pending

default The Travis build is in progress
Details
@mysteriouspants
Contributor

& done, plus I confirmed that it actually works (./configure --default-version=19 --cc=clang --cxx=clang++; rake clean; rake build;).

@travisbot

This pull request passes (merged 78da8b2 into 65b5f2c).

@mysteriouspants
Contributor

Wouldn't be complete without:

win

Thanks for having the patience to let me help fix this one! You guys rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment