Failing spec for String#tr. #1872

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@floere
floere commented Aug 20, 2012

"hello".tr("helo", "1212").should == "12112" but incorrectly results in "122222". The pull request contains a more comprehensive example.

Please also see #1871 for a more in-depth description of the problem.

@travisbot

This pull request fails (merged ccc968e into af9f288).

@ileitch
Member
ileitch commented Aug 20, 2012

You forgot to tag it :)

@floere
floere commented Aug 20, 2012

Is it my job to decide whether something is OK to be broken or not?
Am 20.08.2012 17:20 schrieb "Ian Leitch" notifications@github.com:

You forgot to tag it :)


Reply to this email directly or view it on GitHubhttps://github.com/rubinius/rubinius/pull/1872#issuecomment-7872577.

@floere
floere commented Aug 20, 2012

P.S: Please point me to a relevant piece of information on what/how/why to
tag. Thanks!
Am 20.08.2012 17:30 schrieb "Florian Hanke" florian.hanke@gmail.com:

Is it my job to decide whether something is OK to be broken or not?
Am 20.08.2012 17:20 schrieb "Ian Leitch" notifications@github.com:

You forgot to tag it :)


Reply to this email directly or view it on GitHubhttps://github.com/rubinius/rubinius/pull/1872#issuecomment-7872577.

@carlosgaldino
Member

@floere http://rubyspec.org/mspec-tag/

More precisely bin/mspec tag spec/ruby/core/string/tr_spec.rb

@floere
floere commented Aug 20, 2012

Thanks Carlos, will do.
Am 20.08.2012 18:13 schrieb "Carlos Galdino" notifications@github.com:

@floere https://github.com/floere http://rubyspec.org/mspec-tag/

More precisely bin/mspec tag spec/ruby/core/string/tr_spec.rb


Reply to this email directly or view it on GitHubhttps://github.com/rubinius/rubinius/pull/1872#issuecomment-7874414.

@jc00ke
Member
jc00ke commented Aug 20, 2012
@dbussink
Member

There is actually already a failing spec that we have tagged that exposes the same issue. We don't want to create duplicate specs / add more complex specs if we only really need a simple case to cover the behavior.

I'm actually looking at fixing the already existing specs, to fix the bug we talked about.

@floere
floere commented Aug 20, 2012

I'm fine with this not getting pulled. So, @dbussink you will fix? Then I'll close this and do not fix?

@floere
floere commented Aug 21, 2012

@jc00ke Thanks for the link!

I'm closing this one.

@floere floere closed this Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment