Fix for Matrix.hermitian? #1883

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@chris-baynes

Fix for ruby 1.9 compatibility.
When there are complex values on the matrix diagonal then hermitian? must return false.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Sep 2, 2012

This pull request fails (merged c5c2150 into 149a364).

This pull request fails (merged c5c2150 into 149a364).

@dbussink

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Sep 2, 2012

Owner

If this is not a bug in 1.9, we probably want to update our version. The stuff in lib/ is mostly a direct import from MRI, so we don't want to maintain our own version if we don't have to. Right now our lib/19/matrix.rb is a copy from MRI we took at a certain point, but of course we can update that then.

Owner

dbussink commented Sep 2, 2012

If this is not a bug in 1.9, we probably want to update our version. The stuff in lib/ is mostly a direct import from MRI, so we don't want to maintain our own version if we don't have to. Right now our lib/19/matrix.rb is a copy from MRI we took at a certain point, but of course we can update that then.

@chris-baynes

This comment has been minimized.

Show comment Hide comment
@chris-baynes

chris-baynes Sep 2, 2012

You have a point, it seems this is still a bug in 1.9 (fix is only in ruby-head right now). So I guess it's not really a 1.9 incompatibility and should be left as a 'bug'. Do you prefer to stay as close to MRI as possible in terms of functionality (including possible bugs)?

You have a point, it seems this is still a bug in 1.9 (fix is only in ruby-head right now). So I guess it's not really a 1.9 incompatibility and should be left as a 'bug'. Do you prefer to stay as close to MRI as possible in terms of functionality (including possible bugs)?

@dbussink

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Sep 3, 2012

Owner

The this is not that we want to be bug for bug compatible. What we don't want is to be basically ending up forking stuff in lib/ if it's not necessary. We don't want to add stuff to our maintenance burden if we don't really have to and when there is no pressing reason.

Because of this, I'm not convinced it's worth it at this point to maintain our version of lib/19/matrix.rb. Do you know whether the fix will be backported to 1.9.3? If so, we can update to that version then.

Owner

dbussink commented Sep 3, 2012

The this is not that we want to be bug for bug compatible. What we don't want is to be basically ending up forking stuff in lib/ if it's not necessary. We don't want to add stuff to our maintenance burden if we don't really have to and when there is no pressing reason.

Because of this, I'm not convinced it's worth it at this point to maintain our version of lib/19/matrix.rb. Do you know whether the fix will be backported to 1.9.3? If so, we can update to that version then.

@chris-baynes

This comment has been minimized.

Show comment Hide comment
@chris-baynes

chris-baynes Sep 3, 2012

Ok, I'll close this PR then for now. I presume the fix will be backported at some point. Thanks for your time.

Ok, I'll close this PR then for now. I presume the fix will be backported at some point. Thanks for your time.

brixen added a commit that referenced this pull request Jan 16, 2018

Update rubygems to 2.7.4.
Updating rubygems-update
Successfully installed rubygems-update-2.7.4
Installing RubyGems 2.7.4

=== 2.6.14 / 2017-10-09

Security fixes:

* Whitelist classes and symbols that are in loaded YAML.
  See CVE-2017-0903 for full details.
  Fix by Aaron Patterson.

=== 2.6.13 / 2017-08-27

Security fixes:

* Fix a DNS request hijacking vulnerability. (CVE-2017-0902)
  Discovered by Jonathan Claudius, fix by Samuel Giddins.
* Fix an ANSI escape sequence vulnerability. (CVE-2017-0899)
  Discovered by Yusuke Endoh, fix by Evan Phoenix.
* Fix a DOS vulnerability in the `query` command. (CVE-2017-0900)
  Discovered by Yusuke Endoh, fix by Samuel Giddins.
* Fix a vulnerability in the gem installer that allowed a malicious gem
  to overwrite arbitrary files. (CVE-2017-0901)
  Discovered by Yusuke Endoh, fix by Samuel Giddins.

=== 2.6.12 / 2017-04-30

Bug fixes:

* Fix test_self_find_files_with_gemfile to sort expected files. Pull
  request #1880 by Kazuaki Matsuo.
* Fix issue for MinGW / MSYS2 builds and testing. Pull request #1879 by
  MSP-Greg.
* Fix gem open to open highest version number rather than lowest. Pull
  request #1877 by Tim Pope.
* Add a test for requiring a default spec as installed by the ruby
  installer. Pull request #1899 by Samuel Giddins.
* Fix broken --exact parameter to gem command. Pull request #1873 by Jason
  Frey.
* [Installer] Generate backwards-compatible binstubs. Pull request #1904
  by Samuel Giddins.
* Fix pre-existing source recognition on add action. Pull request #1883 by
  Jonathan Claudius.
* Prevent negative IDs in output of #inspect. Pull request #1908 by Vít
  Ondruch.
* Allow Gem.finish_resolve to respect already-activated specs. Pull
  request #1910 by Samuel Giddins.

=== 2.6.11 / 2017-03-16

Bug fixes:

* Fixed broken tests on ruby-head. Pull request #1841 by
  SHIBATA Hiroshi.
* Update vendored Molinillo to 0.5.7. Pull request #1859 by Samuel
  Giddins.
* Avoid activating Ruby 2.5 default gems when possible. Pull request #1843
  by Samuel Giddins.
* Use improved resolver sorting algorithm. Pull request #1856 by
  Samuel Giddins.

=== 2.6.10 / 2017-01-23

Bug fixes:

* Fix `require` calling the wrong `gem` method when it is overridden.
  Pull request #1822 by Samuel Giddins.

=== 2.6.9 / 2017-01-20

Bug fixes:

* Allow initializing versions with empty strings. Pull request #1767 by
  Luis Sagastume.
* Fix TypeError on 2.4. Pull request #1788 by Nobuyoshi Nakada.
* Don't output mkmf.log message if compilation didn't fail. Pull request
  #1808 by Jeremy Evans.
* Fixed broken links and overzealous URL encoding in gem server. Pull
  request #1809 by Nicole Orchard.
* Update vendored Molinillo to 0.5.5. Pull request #1812 by Samuel
  Giddins.
* RakeBuilder: avoid frozen string issue. Pull request #1819 by Olle
  Jonsson.

=== 2.6.8 / 2016-10-29

Bug fixes:

* Improve SSL verification failure message. Pull request #1751
  by Eric Hodel.
* Ensure `to_spec` falls back on prerelease specs. Pull request
  #1755 by André Arko.
* Update vendored Molinillo to 0.5.3. Pull request #1763 by
  Samuel Giddins.

=== 2.6.7 / 2016-09-26

Bug fixes:

* Install native extensions in the correct location when using the
  `--user-install` flag. Pull request #1683 by Noah Kantrowitz.
* When calling `Gem.sources`, load sources from `configuration`
  if present, else use the default sources. Pull request #1699
  by Luis Sagastume.
* Fail gracefully when attempting to redirect without a Location.
  Pull request #1711 by Samuel Giddins.
* Update vendored Molinillo to 0.5.1. Pull request #1714 by
  Samuel Giddins.

=== 2.6.6 / 2016-06-22

Bug fixes:

* Sort installed versions to make sure we install the latest version when
  running `gem update --system`. As a one-time fix, run
  `gem update --system=2.6.6`. Pull request #1601 by David Radcliffe.

------------------------------------------------------------------------------

RubyGems installed the following executables:
	/source/rubinius/rubinius/bin/gem

RubyGems system software updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment