Fix --preserve-prefix expansion #1946

merged 3 commits into from Oct 9, 2012


None yet

2 participants

voxik commented Oct 5, 2012

Directory settings must reflect the --preserve-prefix flag. There is no value in checking if /usr exists if I specify --preserve-prefix --prefix=/usr , since everything is going to be built into staging directory anyway.

voxik added some commits Oct 5, 2012
@voxik voxik Move directory parameters evaluation out of option parsing.
Move the logic into #set_filesystem_paths, since there is not
enough information to correctly evaluate the parameters earlier.
@voxik voxik Don't modify paths if --preserve-prefix option is used.
All compilation output goes into staging directory in this case. There
is no reason to check if there is some colision with some existing
directories in this case.
brixen commented Oct 5, 2012

Your PR doesn't work. See Travis results.

voxik commented Oct 6, 2012

Sorry ... should not send PR at Friday :) Should be fixed now.

@brixen brixen merged commit d6496b2 into rubinius:master Oct 9, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment