Fix rbx report to not overwrite .rubinius_last_error #2025

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

frodsan commented Nov 17, 2012

rbx report is overwritting .rubinius_last_error if the
submission fails.

Fixes #1510.

Fix rbx report to not overwrite .rubinius_last_error
rbx report is overwritting .rubinius_last_error if the
submission fails.

Fixes #1510.
Member

guilleiguaran commented Nov 19, 2012

@frodsan can you check failures of CI?

Contributor

frodsan commented Nov 19, 2012

I don't know if that failure is produced by this PR, I think is related to https://github.com/rubinius/rubinius/blob/master/spec/ruby/library/socket/tcpsocket/recv_nonblock_spec.rb#L28.

Owner

jc00ke commented Nov 19, 2012

Yeah, looks like the socket failure is unrelated. Have we seen this error before though? I don't think I have.

Owner

brixen commented Nov 20, 2012

I have a fix for this coming.

@brixen brixen closed this in 40b0fb4 Nov 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment