pat clang 3.2svn on the head #2036

Closed
wants to merge 1 commit into
from

3 participants

@ttilley

mark a few private variables as attribute((unused)) to compile with -Werror and the apparently new -Wunused-private-field

fix a logic error in bert where it was negating a boolean and comparing that to an enum rather than comparing against the enum and negating the result of the comparison

@ttilley ttilley pat clang 3.2svn on the head
mark a few private variables as __attribute__((unused)) to compile with -Werror and the apparently new -Wunused-private-field
fix a logic error in bert where it was negating a boolean and comparing that to an enum rather than comparing against the enum and negating the result of the comparison
c943f91
@dbussink dbussink commented on the diff Nov 19, 2012
vm/util/bert.hpp
@@ -895,7 +895,7 @@
Value* new_dict() {
Term* list = tzr_.next_term();
- if(!list->type() == Term::List) {
+ if(!(list->type() == Term::List)) {
@dbussink
Rubinius member
dbussink added a line comment Nov 19, 2012

we should make this a != then

@ttilley
ttilley added a line comment Nov 21, 2012

can this individual change be made in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@brixen
Rubinius member

The usused warnings need to be investigated. Either clang has a bug or we need to fix some code. I don't want to add attributes like that.

@ttilley

I'll have to re-run with the clang 3.2 rc1 to see if the warnings are less harsh. i do see some chatter about -Wunused-private-field potentially ignoring the implementation? ::shrug::

@dbussink dbussink added a commit that referenced this pull request Nov 25, 2012
@dbussink dbussink Cleanup of unused code
Related to #2036
49fd6db
@dbussink dbussink added a commit that closed this pull request Nov 26, 2012
@dbussink dbussink Only pass down state into agent components
We can use the state to grab additional stuff when needed.

Fixes #2036
9d9e154
@dbussink dbussink closed this in 9d9e154 Nov 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment