New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FFI::Platform.windows? (fixes #2064) #2066
Conversation
The spec/core/ffi files are from before the spec/ruby/optional/ffi specs. The spec/core/ffi specs are deprecated and will be removed. Could you ensure that the specs are in spec/ruby/optional/ffi or add them? |
Thank you @brixen I've just added FFI::Platform specs. (git question: is this right to rebase before adding some commits for you?) |
@nibua-r yes, please rebase to master HEAD. |
@brixen Isn't it what I have done? |
@nibua-r I'm not sure, looks weird here. I'll merge manually. |
Thanks @brixen That's strange, I'll check that back at home. |
Strange. Anyway, thank you. I'll check if some action is required when back aT home. Brian Ford notifications@github.com a écrit :
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté. |
One more thing, apparently you changed / touched lib/ext/melbourne/grammar18.cpp, that's probably not intended. |
I'm really sorry I'll fix this ASAP Dirkjan Bussink notifications@github.com a écrit :
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté. |
Should be fixed now. |
|
||
platform_is :darwin do | ||
it "returns true" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've made a typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please be more precise? For me, I'm testing a module method so I use FFI::Platform.windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platform is darwin. Why would #windows?
return true? (the test itself actually asserts that it should be false).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arff, my bad! I'll fix this now… anyway, who cares about darwin ;) No kidding: thank you and I'm sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo was there before me: https://github.com/rubinius/rubinius/blob/master/spec/core/ffi/platform_spec.rb#L36-L41
… but I didn't catch it…
I'll review and fix this.
No description provided.