Add FFI::Platform.windows? (fixes #2064) #2066

Merged
merged 4 commits into from Dec 2, 2012

Conversation

Projects
None yet
3 participants
@nibua-r
Contributor

nibua-r commented Dec 1, 2012

No description provided.

@brixen

This comment has been minimized.

Show comment Hide comment
@brixen

brixen Dec 1, 2012

Owner

The spec/core/ffi files are from before the spec/ruby/optional/ffi specs. The spec/core/ffi specs are deprecated and will be removed. Could you ensure that the specs are in spec/ruby/optional/ffi or add them?

Owner

brixen commented Dec 1, 2012

The spec/core/ffi files are from before the spec/ruby/optional/ffi specs. The spec/core/ffi specs are deprecated and will be removed. Could you ensure that the specs are in spec/ruby/optional/ffi or add them?

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 1, 2012

Contributor

Thank you @brixen

I've just added FFI::Platform specs. (git question: is this right to rebase before adding some commits for you?)

Contributor

nibua-r commented Dec 1, 2012

Thank you @brixen

I've just added FFI::Platform specs. (git question: is this right to rebase before adding some commits for you?)

@brixen

This comment has been minimized.

Show comment Hide comment
@brixen

brixen Dec 1, 2012

Owner

@nibua-r yes, please rebase to master HEAD.

Owner

brixen commented Dec 1, 2012

@nibua-r yes, please rebase to master HEAD.

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 1, 2012

Contributor

@brixen Isn't it what I have done?

Contributor

nibua-r commented Dec 1, 2012

@brixen Isn't it what I have done?

@nibua-r nibua-r referenced this pull request in larskanis/libusb Dec 1, 2012

Closed

Doc improvements #5

@brixen

This comment has been minimized.

Show comment Hide comment
@brixen

brixen Dec 1, 2012

Owner

@nibua-r I'm not sure, looks weird here. I'll merge manually.

Owner

brixen commented Dec 1, 2012

@nibua-r I'm not sure, looks weird here. I'll merge manually.

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 1, 2012

Contributor

Thanks @brixen That's strange, I'll check that back at home.

Contributor

nibua-r commented Dec 1, 2012

Thanks @brixen That's strange, I'll check that back at home.

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 1, 2012

Contributor

Strange. Anyway, thank you. I'll check if some action is required when back aT home.

Brian Ford notifications@github.com a écrit :

@nibua-r I'm not sure, looks weird here. I'll merge manually.


Reply to this email directly or view it on GitHub:
#2066 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

Contributor

nibua-r commented Dec 1, 2012

Strange. Anyway, thank you. I'll check if some action is required when back aT home.

Brian Ford notifications@github.com a écrit :

@nibua-r I'm not sure, looks weird here. I'll merge manually.


Reply to this email directly or view it on GitHub:
#2066 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@dbussink

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Dec 2, 2012

Owner

One more thing, apparently you changed / touched lib/ext/melbourne/grammar18.cpp, that's probably not intended.

Owner

dbussink commented Dec 2, 2012

One more thing, apparently you changed / touched lib/ext/melbourne/grammar18.cpp, that's probably not intended.

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 2, 2012

Contributor

I'm really sorry I'll fix this ASAP

Dirkjan Bussink notifications@github.com a écrit :

One more thing, apparently you changed / touched
lib/ext/melbourne/grammar18.cpp, that's probably not intended.


Reply to this email directly or view it on GitHub:
#2066 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

Contributor

nibua-r commented Dec 2, 2012

I'm really sorry I'll fix this ASAP

Dirkjan Bussink notifications@github.com a écrit :

One more thing, apparently you changed / touched
lib/ext/melbourne/grammar18.cpp, that's probably not intended.


Reply to this email directly or view it on GitHub:
#2066 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@nibua-r

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 2, 2012

Contributor

Should be fixed now.

Contributor

nibua-r commented Dec 2, 2012

Should be fixed now.

spec/core/ffi/platform_spec.rb
+
+ platform_is :darwin do
+ it "returns true" do

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 2, 2012

Looks like you've made a typo here.

@ghost

ghost Dec 2, 2012

Looks like you've made a typo here.

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 2, 2012

Contributor

Could you please be more precise? For me, I'm testing a module method so I use FFI::Platform.windows?

@nibua-r

nibua-r Dec 2, 2012

Contributor

Could you please be more precise? For me, I'm testing a module method so I use FFI::Platform.windows?

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 2, 2012

The platform is darwin. Why would #windows? return true? (the test itself actually asserts that it should be false).

@ghost

ghost Dec 2, 2012

The platform is darwin. Why would #windows? return true? (the test itself actually asserts that it should be false).

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 2, 2012

Contributor

Arff, my bad! I'll fix this now… anyway, who cares about darwin ;) No kidding: thank you and I'm sorry.

@nibua-r

nibua-r Dec 2, 2012

Contributor

Arff, my bad! I'll fix this now… anyway, who cares about darwin ;) No kidding: thank you and I'm sorry.

This comment has been minimized.

Show comment Hide comment
@nibua-r

nibua-r Dec 2, 2012

Contributor

The typo was there before me: https://github.com/rubinius/rubinius/blob/master/spec/core/ffi/platform_spec.rb#L36-L41
… but I didn't catch it…

I'll review and fix this.

@nibua-r

nibua-r Dec 2, 2012

Contributor

The typo was there before me: https://github.com/rubinius/rubinius/blob/master/spec/core/ffi/platform_spec.rb#L36-L41
… but I didn't catch it…

I'll review and fix this.

spec/ruby/optional/ffi/platform_spec.rb
+ end
+
+ platform_is :darwin do
+ it "returns true" do

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 2, 2012

Same typo here.

@ghost

ghost Dec 2, 2012

Same typo here.

spec/ruby/optional/ffi/platform_spec.rb
+ end
+
+ platform_is :darwin do
+ it "returns true" do

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 2, 2012

Another one here.

@ghost

ghost Dec 2, 2012

Another one here.

@brixen brixen merged commit 7fd1ba9 into rubinius:master Dec 2, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment