Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Array and add Reflector #2077

Closed
wants to merge 2 commits into from
Closed

Cleanup Array and add Reflector #2077

wants to merge 2 commits into from

Commits on Dec 4, 2012

  1. Remove Array.attr_accessor :total

    @evanphx
    evanphx committed Dec 4, 2012
    Copy the full SHA
    2dd95c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2012

  1. Clean Array by using a Reflector (simple mirror) 

    Array left it's guts exposed to deal with the way that data has to be
exposed in ruby. To clean things up, I've introduce a Reflector class
which is a simple mirror. This can easily access the internal data of an
object. Additionally, rather than using instance_variable_[get|set] the
JIT can make access quite fast because it doesn't have to deal with any
edgecases.
    @evanphx
    evanphx committed Dec 5, 2012
    Copy the full SHA
    0b96773 View commit details
    Browse the repository at this point in the history