Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add type definitions for :buffer_in and :buffer_out #2099

Closed
wants to merge 1 commit into from

2 participants

Daniel Vartanov Brian Shirai
Daniel Vartanov

Not sure if specs should be added here. :buffer_in and :buffer_out are just another names of the same type (pointer), i.e. go into the same class of equivalence.

Rubinius actually has specs which use :buffer_in and :buffer_out, but those specs also rely on FFI::Buffer, which is not implemented yet.

Brian Shirai
Owner

Please hold off on more FFI PRs. I'm going to work on getting the ffi gem to run on Rubinius.

Daniel Vartanov

Ok, good. Let me know if you need help with that.

Brian Shirai
Owner

We now bundle a 1.2.0 version of the FFI gem, however, there is a bug in RVM that omits the pre-installed gems. So if using RVM, use the recently released 1.3.0 FFI gem which builds correctly on Rubinius.

Brian Shirai brixen closed this
Daniel Vartanov

That's great, thank you for informing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  kernel/platform/ffi.rb
2  kernel/platform/ffi.rb
View
@@ -129,6 +129,8 @@ def errno
# Converts a pointer to opaque data
add_typedef TYPE_PTR, :pointer
+ add_typedef TYPE_PTR, :buffer_in
+ add_typedef TYPE_PTR, :buffer_out
# For when a function has no return value
add_typedef TYPE_VOID, :void
Something went wrong with that request. Please try again.