Make library/socket/socket/connect_nonblock_spec pass #2101

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@sdaubert
Contributor

In spec, I have replaced comparison between returned value by #getsockopt and an integer with a comparison with a packed string, as it is done in basicsocket/getsockopt_spec.

sdaubert added some commits Dec 19, 2012
@sdaubert sdaubert * spec/ruby/library/socket/socket/connect_nonblock_spec.rb:
  make spec "takes an encoded socket address and starts the connection to it"
  pass. Returned value from #getsockopt is compared with a packed string as
  it is done in basicsockt/getsockopt_spec.
410157d
@sdaubert sdaubert * remove fail tag on library/socket/socket/connect_nonblock. e7dd166
@sdaubert sdaubert Merge branch 'master' of git://github.com/rubinius/rubinius f6d6568
@dbussink
Member

Hmm, this passes on MRI 1.9, but not 1.8. Looks like behavior that was changed between those versions. The specs need to be updated then to reflect that change. Also means that Rubinius has to be fixed for this in 1.9 mode.

@sdaubert
Contributor

Travis build is passed now. I don't know why.

@dbussink
Member

This doesn't have anything to do with Travis, but with running the specs against MRI. On Travis we only run the specs against Rubinius.

All the specs in spec/ruby are a copy of Rubyspec. Rubyspec describes how MRI behaves, so the specs should describe that behavior. If MRI 1.8 and 1.9 behave different in this area, this should be described in the specs. This is what I was referring to that should be fixed in the specs.

@sdaubert
Contributor

Close it as I change a spec without testing it on MRI.

@sdaubert sdaubert closed this Dec 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment