Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Socket.getaddrinfo handles special hosts '<any>' and '<broadcast>' #2115
As said on rubinius#2111, here is the new pull request to handle special hosts '' and '', without converting last item on returned array to a packed string.
This pull request also contains a commit to modify specs "Socket#gethostbyname returns broadcast address info for '
referenced this pull request
Jan 4, 2013
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Ok, looks good! One thing though, could you improve the layout of the commit messages? For example https://github.com/sdaubert/rubinius/commit/b24e1aa261bf6a660efa923b061fc2549ed89d08 has a long first line that overflows and the line breaks in the lines further seem weird too. In general the recommendation is to use up to 72 char lines.
Usually how it looks on github can be a good guideline for the messages. For a multiple line commit message, also use a newline after the first line and multiple paragraphs for really long texts.