Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

inttypes.h needed in vendor/oniguruma/transcoder.h for OpenBSD #2119

Merged
merged 1 commit into from Jan 9, 2013

Conversation

Projects
None yet
4 participants
Contributor

tonysidaway commented Jan 9, 2013

This is needed for a clean build on OpenBSD.

brixen pushed a commit that referenced this pull request Jan 9, 2013

Merge pull request #2119 from tonysidaway/openbsd
inttypes.h needed in vendor/oniguruma/transcoder.h  for OpenBSD

@brixen brixen merged commit 8a8138d into rubinius:master Jan 9, 2013

1 check passed

default The Travis build passed
Details
Owner

dbussink commented on 76dd7c0 Jan 9, 2013

Any reason this is conditional? If it's a generic header that should exist on every platform, I'd rather not add conditional loading for it.

Contributor

Gibheer replied Jan 9, 2013

I can confirm that it exists on linux and freebsd.

Contributor

tonysidaway commented Jan 9, 2013

I made the include conditional because its absence breaks the build on OpenBSD and presumably not on other platforms. But dbussink's argument for including it always is sound--provided the header file truly does exist on all platforms. Another possibility, which I haven't investigated, is that this is non-standard behaviour by OpenBSD and should be fixed there (as the setenv problem was a few months ago).

Owner

dbussink commented Jan 9, 2013

Actually checked and and inttypes.h looks to be a standard header: http://pubs.opengroup.org/onlinepubs/009604599/basedefs/inttypes.h.html

We also checked it's available on at least Linux, OS X and FreeBSD so I already removed the conditional in 7f52895.

Thanks for keeping it running on OpenBSD :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment