Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for IO.readlines(name, options) with implicit separator #2271

Merged
merged 2 commits into from Apr 14, 2013

Conversation

Projects
None yet
2 participants
Member

leocassarani commented Apr 12, 2013

This allows the method to be called with IO.readlines("foo", :encoding => "utf-8"), which matches MRI behaviour, instead of raising a Coercion error as before.

Member

leocassarani commented Apr 12, 2013

Not quite ready for merge yet, I'll be adding specs and fixing an annoying edge case.

leocassarani added some commits Apr 12, 2013

Add support for IO.readlines(name, options) with implicit separator
This allows a call such as IO.readlines("foo", :encoding => "utf-8"),
instead of raising a Coercion error as before.
Owner

dbussink commented Apr 13, 2013

BTW, might be good to check if there are more IO methods that need to support this hash style

dbussink added a commit that referenced this pull request Apr 14, 2013

Merge pull request #2271 from leocassarani/readlines-encoding
Add support for IO.readlines(name, options) with implicit separator

@dbussink dbussink merged commit 2a48187 into rubinius:master Apr 14, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment