Replace a reserved Symbol :_alone instead of :_singleton for Enumerable#chunk #2305

Merged
merged 3 commits into from Apr 23, 2013

Conversation

Projects
None yet
5 participants
@kachick
Member

kachick commented Apr 22, 2013

No description provided.

kernel/common/enumerable19.rb
yielder.yield [key, [val]]
else
- raise RuntimeError, "symbol beginning with an underscore are reserved"
+ raise RuntimeError, "symbol begins with an underscore is reserved"

This comment has been minimized.

Show comment Hide comment
@leocassarani

leocassarani Apr 22, 2013

Member

I'm not sure we should be making our exception strings ungrammatical in the name of matching what MRI does. Can we simply fix the typo in the original sentence and leave it as "symbols beginning with an underscore are reserved"?

P.S. I realise English may not be your first language, so apologies if this comes across overly critical.

@leocassarani

leocassarani Apr 22, 2013

Member

I'm not sure we should be making our exception strings ungrammatical in the name of matching what MRI does. Can we simply fix the typo in the original sentence and leave it as "symbols beginning with an underscore are reserved"?

P.S. I realise English may not be your first language, so apologies if this comes across overly critical.

This comment has been minimized.

Show comment Hide comment
@jc00ke

jc00ke Apr 22, 2013

Owner

I was just about to make the same comment. I don't think we should be matching MRI here.

@jc00ke

jc00ke Apr 22, 2013

Owner

I was just about to make the same comment. I don't think we should be matching MRI here.

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 22, 2013

Member

Thank you for letting me know!
I'll remove this commit.

@kachick

kachick Apr 22, 2013

Member

Thank you for letting me know!
I'll remove this commit.

This comment has been minimized.

Show comment Hide comment
@leocassarani

leocassarani Apr 22, 2013

Member

Could you go one step further and add an "s" to the end of "symbol"? As in, "symbols beginning with...". You can amend the original commit if you like.

@leocassarani

leocassarani Apr 22, 2013

Member

Could you go one step further and add an "s" to the end of "symbol"? As in, "symbols beginning with...". You can amend the original commit if you like.

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 22, 2013

Member

Sure.

@kachick

kachick Apr 22, 2013

Member

Sure.

This comment has been minimized.

Show comment Hide comment
@agrimm

agrimm May 3, 2013

Contributor

In future, when fixing grammar like this, it may be worthwhile suggesting the same edit to MRI.

@agrimm

agrimm May 3, 2013

Contributor

In future, when fixing grammar like this, it may be worthwhile suggesting the same edit to MRI.

dbussink added a commit that referenced this pull request Apr 23, 2013

Merge pull request #2305 from kachick/fix-enumerable-chunk
Replace a reserved Symbol :_alone instead of :_singleton for Enumerable#chunk

@dbussink dbussink merged commit 93408f4 into rubinius:master Apr 23, 2013

1 check failed

default The Travis build failed
Details

@kachick kachick deleted the kachick:fix-enumerable-chunk branch Apr 23, 2013

@agrimm

This comment has been minimized.

Show comment Hide comment
@agrimm

agrimm May 3, 2013

Are you a time traveller? I filed a bug report for this with YARV on May 1. 😲

agrimm commented on 21a7430 May 3, 2013

Are you a time traveller? I filed a bug report for this with YARV on May 1. 😲

This comment has been minimized.

Show comment Hide comment
@kachick

kachick May 3, 2013

Owner

No.
I think "John Titor" is @leocassarani. 😄

rubinius#2305 (comment)

Owner

kachick replied May 3, 2013

No.
I think "John Titor" is @leocassarani. 😄

rubinius#2305 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment