Enumerator#peek_values, Enumerator#next_values #2307

Merged
merged 4 commits into from Apr 23, 2013

Conversation

Projects
None yet
2 participants
@kachick
Member

kachick commented Apr 23, 2013

No description provided.

+ @e.next.should == :c
+ end
+
+ it "can be called repeatedly with advancing the position of the current element" do

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Apr 23, 2013

Owner

A few description suggestions in the following comments:

it "advances the position of the enumerator each time when called multiple times"

@dbussink

dbussink Apr 23, 2013

Owner

A few description suggestions in the following comments:

it "advances the position of the enumerator each time when called multiple times"

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 23, 2013

Member

Thank you. It looks good to me.
I'll replace it.

@kachick

kachick Apr 23, 2013

Member

Thank you. It looks good to me.
I'll replace it.

+ @e.next_values.should == [:a]
+ end
+
+ it "returns a nil-only-array if the yield called with nil" do

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Apr 23, 2013

Owner

it "returns an array with only nil if yield is called with nil"

@dbussink

dbussink Apr 23, 2013

Owner

it "returns an array with only nil if yield is called with nil"

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 23, 2013

Member

Thanks!
I'll replace peek_values spec too.

@kachick

kachick Apr 23, 2013

Member

Thanks!
I'll replace peek_values spec too.

+ @e.next_values.should == [nil]
+ end
+
+ it "returns an empty array if the yield called without arguments" do

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Apr 23, 2013

Owner

it "returns an empty array if yield is called without arguments"

@dbussink

dbussink Apr 23, 2013

Owner

it "returns an empty array if yield is called without arguments"

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 23, 2013

Member

Thanks!

@kachick

kachick Apr 23, 2013

Member

Thanks!

+ @e.peek_values.should == [nil]
+ end
+
+ it "returns an empty array if the yield called without arguments" do

This comment has been minimized.

Show comment Hide comment
@dbussink

dbussink Apr 23, 2013

Owner

it "returns an empty array if yield is called without arguments"

@dbussink

dbussink Apr 23, 2013

Owner

it "returns an empty array if yield is called without arguments"

This comment has been minimized.

Show comment Hide comment
@kachick

kachick Apr 23, 2013

Member

Thanks!

@kachick

kachick Apr 23, 2013

Member

Thanks!

dbussink added a commit that referenced this pull request Apr 23, 2013

Merge pull request #2307 from kachick/enumerator-peek,next_values
Enumerator#peek_values, Enumerator#next_values

@dbussink dbussink merged commit 0483eb4 into rubinius:master Apr 23, 2013

1 check passed

default The Travis build passed
Details

@kachick kachick deleted the kachick:enumerator-peek,next_values branch Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment