New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added string#scan benchmark and associated test file holmes.txt #2824

Merged
merged 3 commits into from Dec 12, 2013

Conversation

Projects
None yet
3 participants
@kwleland
Copy link
Contributor

kwleland commented Dec 10, 2013

per issue 2821

require 'benchmark/ips'

long_text = File.new('holmes.txt').read.downcase
#holmes.txt @ http://norvig.com/holmes.txt

This comment has been minimized.

@jc00ke

jc00ke Dec 10, 2013

Member

Did you mean for this comment to be indented?

@kwleland

This comment has been minimized.

Copy link
Contributor

kwleland commented Dec 10, 2013

I thought it was a tad less distracting but thats just an opinion. I'm not super invested in it.

@jc00ke

This comment has been minimized.

Copy link
Member

jc00ke commented Dec 11, 2013

What about using benchmark/core/file/*.txt? Is there a reason to introduce a new fixture?

Kenneth Leland and others added some commits Dec 11, 2013

@kwleland

This comment has been minimized.

Copy link
Contributor

kwleland commented Dec 12, 2013

Is there anything else I need to do to get this merged?

@dbussink

This comment has been minimized.

Copy link
Member

dbussink commented Dec 12, 2013

Nope :).

dbussink added a commit that referenced this pull request Dec 12, 2013

Merge pull request #2824 from kwleland/bench_scan
added string#scan benchmark and associated test file holmes.txt

@dbussink dbussink merged commit f945437 into rubinius:master Dec 12, 2013

1 check passed

default The Travis CI build passed
Details

@markijbema markijbema referenced this pull request Dec 12, 2013

Open

String#scan is slow #2821

@kwleland kwleland deleted the kwleland:bench_scan branch Dec 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment