Fixed a problem where splatted nil would get converted to [nil]. #2938

Merged
merged 1 commit into from Feb 12, 2014

4 participants

@razielgn

Fixes #2926.

Here's the video recording of the short debugging session with @dbussink http://www.youtube.com/watch?v=HpHjvbxX2a0
I'll write a short blog post about it in the following days, as requested by @dbussink. 😃

@razielgn razielgn Fixed a problem where splatted nil would get converted to [nil].
Fixes #2926.

Previously, the JIT code was not checking for nil, when trying to cast
the stack value to an array, thus creating an array with just nil in it.
This fix ensures an empty array gets created instead.

With help from @dbussink, and recorded it live on an hangout!
e1b064c
@dbussink dbussink merged commit a772b9d into rubinius:master Feb 12, 2014

1 check passed

Details default The Travis CI build passed
@dbussink
Rubinius member

Thanks!

@tak1n
Rubinius member

Thanks for the interesting video 👍

@ileitch
Rubinius member

Awesome, thank you.

@razielgn razielgn deleted the unknown repository branch Feb 21, 2014
@razielgn

I didn't forget about the blog post, it's being written. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment