Regexp new with numbers #2960

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Owner

jc00ke commented Mar 2, 2014

Adding on to the if/elsif chain feels dirty. Suggestions, or leave as is?

Owner

dbussink commented Mar 2, 2014

Shouldn't this implement a coercion protocol like we have in place in a lot of other places?

Owner

jc00ke commented Mar 2, 2014

Owner

dbussink commented Mar 2, 2014

I suspect this should be string coercion, but not sure. We should also check behavior like calling to_s / to_str in the argument.

jc00ke closed this Mar 2, 2014

jc00ke deleted the regexp-new-with-numbers branch Mar 2, 2014

Owner

jc00ke commented Mar 2, 2014

Will reopen when it's actually a decent PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment