Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for #3360 (case-when with splatted arrays from variables). #3362

Merged
merged 1 commit into from Mar 18, 2015
Merged

Add specs for #3360 (case-when with splatted arrays from variables). #3362

merged 1 commit into from Mar 18, 2015

Conversation

maltoe
Copy link
Contributor

@maltoe maltoe commented Mar 17, 2015

See issue #3360.

Add specs for rubinius#3360 (case-when with splatted arrays from vari…
f4a22e9 
…ables).

This adds some test cases for rubinius#3360. Rubinius 2.5.2 fails to compile
case-when statements with splatted arrays coming from variables. Only
the latter two specs fail, though.
@jemc
Copy link
Member

jemc commented Mar 18, 2015

Ah, so FYI, normally I would ask that you run mspec tag fails spec/ruby/language/case_spec.rb to have mspec run through the new tests and tag them as failing in a file in the spec/tags subdirectory so that the CI would skip those tests and still pass. However, in this case, because it's a compiler error it's impossible to even do that much, because the file can't even be loaded. Also, the fact that the bug is in the Rubinius code tools gems makes this a little more difficult to deal with as well.

So here's what I'll do - I'll pull your tests down locally to work on the fix on my dev machine. I'll push a fix to the rubinius-ast gem, then get @brixen to do a release of the gem. Then we can bump the version of rubinius-ast that Rubinius depends on and the issue will be fixed on master, and I can merge these tests in this PR because they'll pass.

@jemc jemc self-assigned this Mar 18, 2015
jemc added a commit that referenced this pull request Mar 18, 2015
@jemc
Merge pull request #3362 from FlavourSys/specs-for-issue-3360
4b28804 
Add specs for #3360 (case-when with splatted arrays from variables).
@jemc jemc merged commit 4b28804 into rubinius:master Mar 18, 2015
@jemc
Copy link
Member

jemc commented Mar 18, 2015

@maltoe
Thanks for reporting and for writing some specs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jemc jemc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maltoe @jemc