Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Comparable#== to use a recursion guard #3452

merged 3 commits into from Jun 26, 2015


Copy link

@eregon eregon commented Jun 26, 2015

Changes Comparable#== to use a recursion guard instead of rescuing a SystemStackError.

Stack overflows should generally not be caught and the user #<=> should be called only once (instead of 1214 in my environment).

Copy link

brixen commented Jun 26, 2015

Thanks, @eregon.

brixen added a commit that referenced this pull request Jun 26, 2015
Change Comparable#== to use a recursion guard
@brixen brixen merged commit 7f7d57b into rubinius:master Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants