Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #instance_eval to evaluate procs originated from methods #3543

Conversation

@ahmadsherif
Copy link
Member

@ahmadsherif ahmadsherif commented Dec 26, 2015

No description provided.

@@ -138,4 +138,13 @@ class B; end
(1 << 64).instance_eval { def foo; end }
end.should raise_error(TypeError)
end

it "evaluates procs originated from methods" do
Copy link
Member

@YorickPeterse YorickPeterse Dec 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "originating from methods".

Copy link
Member Author

@ahmadsherif ahmadsherif Dec 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ahmadsherif ahmadsherif force-pushed the fix/calling-instance-eval-with-procs-originated-from-methods branch from e0611bc to 306a957 Dec 26, 2015
@YorickPeterse
Copy link
Member

@YorickPeterse YorickPeterse commented Dec 26, 2015

Rebased into f0d2089 and a246ed6, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants